On Mon, Jan 17, 2011 at 4:44 PM, Gijs de Rooy wrote: > Hi Melchior, > > I was about to send an email to the mailing list asking for feedback, so > thanks for saving > my three minutes :) > >> Shudder! This patch simply duplicates a lot of code that was meant >> to be *re-used*. > > Right. So far it was a proof of concept. What it needs now is someone to > clean the code > up and improve it. I agree that it might have been better to distribute it > through a diff, > rather than commiting it yet, though; but given the fact that it only adds > something (and > doesn't break anything else; atleast it should not) it is not a very big > deal I think to have > it temporarily like this in Git... (don't get me wrong, I won't say it was > right to do!)
Hi Gijs, Are you actively working on this feature, or expecting someone else to clean it up? In addition to the coding issues that Melchior has highlighted, I've noticed a couple of basic functional problems: 1) Typo in the menu bar "Screesnhot (set directory)". At minimum you should correct the typo, and I would suggest changing the label to "Set Screenshot Directory", though even that wording is a bit kludgy. 2) On my system I can't see any way to go up a directory using the GUI, so I'm stuck inside /tmp/ unless I enter a directory manually. 3) No Close button on the bottom of the dialog (for consistency with the rest of the UI). This should be fixed in both this and the File Selector dialog class. Being very blunt, while a proof of concept is very nice, I think you need to do more this close to the v2.2.0 release. IMO you need to either address these issues yourself, find someone to do so for you, or back it out. You can't just check in such proof of concept without a plan to bring it up to the normal level of quality. Please let me know which way you intend to go, so I can determine whether to update The Manual or not. -Stuart ------------------------------------------------------------------------------ Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d _______________________________________________ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
