Your message dated Wed, 07 Feb 2018 10:50:33 +0000
with message-id <e1ejnjb-0007mj...@fasolo.debian.org>
and subject line Bug#849110: fixed in magicrescue 1.1.9-6
has caused the Debian Bug report #849110,
regarding magicrescue builds without dupemap support on Ubuntu
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
849110: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=849110
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: magicrescue
Version: 1.1.9-4
Severity: important
Tags: patch
It appears that due to some change in the compiler used by Ubuntu,
magicrescue no longer builds with dupemap support. This is the case
for Yakkety which ships version 1.1.9-3. This is the output you get
when you try to use dupemap:
> dupemap was not compiled because no ndbm.h was found on your system. Please
> install the development packages for Berkeley DB or GDBM and recompile.
I've tried to determine at what point the dupemap command stopped
working in Ubuntu based on what the current archive has, but this may
not be entirely reliable. Version 1.1.9-2 with a time stamp of
2014-11-04 doesn't work either, but version 1.1.8-1 with a time stamp
of 2009-12-18 does. This is very strange, because I could have sworn
I had a working version towards the end of 2015. Perhaps the packages
they have in the archive have been rebuilt with a newer compiler.
Anyway, if I take the source for the working version (1.1.8-1) and
rebuild the package in Yakkety, dupemap doesn't work either. This would
confirm that the problem is not as a result of a change in the source
code, but a change in the compiler.
I have found that if you tweak the position of the LDFLAGS in the
command used to link binaries, everything works as expected again.
Please take a look at my patch.
Thanks,
Carlos
-- System Information:
Debian Release: stretch/sid
APT prefers unstable
APT policy: (990, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.7.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages magicrescue depends on:
ii dcraw 9.27-1
ii flac 1.3.1-4
ii libc6 2.24-8
ii libgdbm3 1.8.3-14
ii libjpeg-turbo-progs 1:1.5.1-2
ii mpg321 [mpg123] 0.3.2-1.1
ii sqlite3 3.15.2-2
ii unzip 6.0-21
ii zip 3.0-11
magicrescue recommends no packages.
magicrescue suggests no packages.
-- no debconf information
From: Carlos Maddela <e7ap...@gmail.com>
Date: Fri, 23 Dec 2016 02:10:17 +1100
Subject: Fix position of LDFLAGS in link commands.
Description: Fix position of LDFLAGS in link commands.
magicrescue builds without dupemap on Ubuntu because the
conftest_link() function in the configure script fails to link
with the gdbm library, due to the position of the LDFLAGS in
the link command. Reordering fixes the problem.
.
The same fix is also required in the Makefile, otherwise the
package will fail to build.
Author: Carlos Maddela <e7ap...@gmail.com>
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
---
Makefile.in | 10 +++++-----
configure | 4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/Makefile.in b/Makefile.in
index ee9038f..a977a90 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -18,19 +18,19 @@ all: $(PROGRAMS) docs
# program targets
magicrescue: $(MAGICRESCUE_OBJS)
- $(CC) -o $@ $(LDFLAGS) $(MAGICRESCUE_OBJS)
+ $(CC) -o $@ $(MAGICRESCUE_OBJS) $(LDFLAGS)
dupemap: $(DUPEMAP_OBJS)
- $(CC) -o $@ $(LDFLAGS) $(DBM_LDFLAGS) $(DUPEMAP_OBJS)
+ $(CC) -o $@ $(DUPEMAP_OBJS) $(LDFLAGS) $(DBM_LDFLAGS)
tools/inputseek: $(INPUTSEEK_OBJS)
- $(CC) -o $@ $(LDFLAGS) $(INPUTSEEK_OBJS)
+ $(CC) -o $@ $(INPUTSEEK_OBJS) $(LDFLAGS)
tools/safecat: $(SAFECAT_OBJS)
- $(CC) -o $@ $(LDFLAGS) $(SAFECAT_OBJS)
+ $(CC) -o $@ $(SAFECAT_OBJS) $(LDFLAGS)
tools/textextract: $(TEXTEXTRACT_OBJS)
- $(CC) -o $@ $(LDFLAGS) $(TEXTEXTRACT_OBJS)
+ $(CC) -o $@ $(TEXTEXTRACT_OBJS) $(LDFLAGS)
# implicit targets
.c.o:
diff --git a/configure b/configure
index 90b2f06..a479ba1 100755
--- a/configure
+++ b/configure
@@ -63,9 +63,9 @@ EOF
}
conftest_link() {
- echo "$CC -o conftest $LDFLAGS conftest.o" >&5
+ echo "$CC -o conftest conftest.o $LDFLAGS" >&5
echo >&5
- $CC -o conftest $LDFLAGS conftest.o >&5 2>&5 \
+ $CC -o conftest conftest.o $LDFLAGS >&5 2>&5 \
&& [ -x conftest ] && ./conftest 2>&5
}
--- End Message ---
--- Begin Message ---
Source: magicrescue
Source-Version: 1.1.9-6
We believe that the bug you reported is fixed in the latest version of
magicrescue, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 849...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Gianfranco Costamagna <locutusofb...@debian.org> (supplier of updated
magicrescue package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 07 Feb 2018 11:31:21 +0100
Source: magicrescue
Binary: magicrescue
Architecture: source
Version: 1.1.9-6
Distribution: unstable
Urgency: medium
Maintainer: Debian Forensics <forensics-devel@lists.alioth.debian.org>
Changed-By: Gianfranco Costamagna <locutusofb...@debian.org>
Description:
magicrescue - recover files by looking for magic bytes
Closes: 849110
Changes:
magicrescue (1.1.9-6) unstable; urgency=medium
.
* Team Upload
[ Carlos Maddela ]
* debian/patches/60_fix-LDFLAG-pos.patch:
- Fix missing gdbm support where gcc has default wl-asneeded flag,
by fixing the linking order (Closes: #849110)
Checksums-Sha1:
b8ffcd762b60f67fe13a430632d21a3123730fd5 1959 magicrescue_1.1.9-6.dsc
02df82037d91e048d35f61d2e0b1fa1a25f8bf5f 7436 magicrescue_1.1.9-6.debian.tar.xz
63255ab6d1c0f05cf6333eb06f5148d578174280 6353
magicrescue_1.1.9-6_source.buildinfo
Checksums-Sha256:
51459220be83b24b7bbd6733df02b3d0c9233bcefb556ef67a33b72b766606e0 1959
magicrescue_1.1.9-6.dsc
b46a634722c06cd5af704b250d317a5762907d2476e5145d54f14c5c1e5fba21 7436
magicrescue_1.1.9-6.debian.tar.xz
9bbdfbc30e5f8a41460e75ab678834ded4367156037ccb1d910647419394f061 6353
magicrescue_1.1.9-6_source.buildinfo
Files:
9b6de31caaf3223a958aba659e1ea2c0 1959 utils optional magicrescue_1.1.9-6.dsc
ddea8f510ef9def21e9df7950bfbe606 7436 utils optional
magicrescue_1.1.9-6.debian.tar.xz
ebf254f2c76a30c598d08f489fa24b89 6353 utils optional
magicrescue_1.1.9-6_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIcBAEBCAAGBQJaetYZAAoJEPNPCXROn13Z/cYQANLRIjItIPXk9CIp2VV/v7fd
ZUlo0WerqoW4JG+PMXZW6MX02Fg7QYhKsYHVKWvYPVx66PuCc77BsADMu71BdC5Z
bPg0gIi/MC4ui+8pUDXqUYAZ9uvOIaxcVF4KToXs0tiLFCkazXxXqGJNEb1o2hkE
7dwekXm8NliWPJiYbtk0wIN4yuwOg6Fi3ZJUJG/YYz2pH7RzApUR1ExacQVakTP7
+2ZeYHxsxMdgx0qCfU7RO70xZIdeEA4REprjiZTxxGrg/t8NG4IMdsx5mJIpZNhh
4WbjqY/jwbLaJ0O6V2y3RetSzqPwRj6+JXuzFmsqQQVpDM5NtaIzi9NFS9Y9tD7C
dWzrn3xmZ0IhFK9h5aDHmZI2DXkQ0yUY848/anrt4A/UYums91bJfXyx9Ra+6l8p
4YoJJucoBba7zfXnEUWPg91WXoR8FPB8beitmxFkoegkpZ6iS5F4PlCH1A+ZBvEX
QJ1Ldy6l4BPuJK34eacwaRi481I97GMNnDN2T2BKll1pXrAD4xFuBrs4JmvXcWBU
RjGxDyunCZOu70j99fQiYKaFjCWNvB1e1oflgDZ1xPwaRxxOHYVPCWEVST6JsfoS
x7okizPyKyjiAPcs6uEcJRZbIQTveZRSCDDIX+Avsnnp98LqnzJRdysubv9KII7U
khlF1NVkVfblIrC2jX3R
=nKlr
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
forensics-devel mailing list
forensics-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/forensics-devel
