On 2013-08-08 10:58, Stephan Beal wrote:
On Thu, Aug 8, 2013 at 10:47 AM, Rene <[email protected]> wrote:-R seems redundant. It's not _entirely_ redundant - in some cases it changes how the arguments are processed. Yes, there are inconsistencies there, but some of the argument handling relies on one or the other approach. When the app looks for a CLI flag, e.g. -R, fossil actually removes that flag and its argument from the global argument list, which changes the argument count, and many of the commands use logic like if(g.argc==3){...}, so there non-obvious side effects when changing whether a command expects -R or not. It the context of libfossil, that's been one of the minor points on the list of things to consider, and while i don't much care for inconsistency in software, i _think_ that i'll end up doing it similar to how it is done now. e.g. a clone implies a -R (but normally in the form of a URL), and doesn't need a flag. The commands you listed where -R is optional almost always derive their repo db from the current checkout (which is why -R is not required). i'm not sure why ui/server don't require -R, but instead take their repo filename as a non-flag argument. Historical in nature, i guess. -- ----- stephan beal http://wanderinghorse.net/home/stephan/ [1] http://gplus.to/sgbeal [2] Links: ------ [1] http://wanderinghorse.net/home/stephan/ [2] http://gplus.to/sgbeal _______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Well lets go the other way a repo, if not in an checkout, must always be specified with -R. and maybe if a -R repo is specified in a checkout the -R takes precedent.
-- Rene _______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
