Thus said Stephan Beal on Sat, 28 Nov 2015 16:56:49 +0100:

> i can't fix this because my left arm is (again) tied up in a sling and
> programming with only 1 hand is exceedingly annoying, but now that the
> problem has  been reproduced, maybe one  of the other devs  can take a
> look at it.

I looked at it and the problem  is that Fossil does not properly respond
to the form it generates here:

http://www.fossil-scm.org/index.html/artifact/49c6b1327a9aea3b0682b2c55bddd9d54860ff6f?txt=1&ln=478,488

When the  user clicks on the  Download button that this  page generates,
the browser sends a request for:

/zip?name=abc&uuid=123

When   Fossil   receives  this   request,   it   doesn't  properly   set
Content-disposition to tell the browser what the name of the file should
be for the data that it sends back in the response.

One potential fix is just to put the filename in the URL:

http://www.fossil-scm.org/index.html/info/5f32bf719d7440d3

A larger fix  might involve adding code to  return a Content-Disposition
header (I have such a patch,  but if the aforementioned fix is suitable,
might as well use it since it is only 1 line change).

Should we instead  be using Content-disposition to  enable clients which
don't include the /RID.zip  portion of the URL to get a  hint as to what
they should call the file?

Andy
-- 
TAI64 timestamp: 40000000565a087a


_______________________________________________
fossil-users mailing list
[email protected]
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to