On Tue, Jun 13, 2017 at 04:19:53PM +0900, [email protected] wrote: > > [837333fc] Fix the blob_read_from_file > thank you.
Actually, it is not completely fix because blob_read_from_file() call blob_read_from_channel() which return a int. Anyway, since the internals of the Blob structure use "unsigned int" to track size and all other functions that deal with Blobs expect "int" or "unsigned int", it would require a lot more changes to really make it works for really big files. The question is, Does it really worth it? Knowing that it would probably slow down for 99.99% of the case, especially on older non 64bit architectures. However, I think the best types for Blob structure is probably size_t. I'm not sure if it's okay to use size_t with C89, but fossil already use it in some places (even in blob.c), so I guess it's not a problem. Regards, -- Martin G. _______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
