On 13 December 2017 at 11:08, Richard Hipp <[email protected]> wrote: > On 12/13/17, jungle Boogie <[email protected]> wrote: >> On 13 December 2017 at 09:07, Warren Young <[email protected]> wrote: >>> On Dec 13, 2017, at 9:55 AM, Richard Hipp <[email protected]> wrote: >>>> >>>> Would Git or GitHub have told me about those prior tickets? >>> >>> GitHub is pretty good about surfacing such information, as long as the >>> ticket references the checkin ID. >> >> Yep. With most projects I follow on github, the commiter includes the >> referenced issue number in the description or somewhere in the commit >> message. > > Is the ticket number included in the check-in that *fixed* the issue, > or in the check-in that *caused* the issue. Therein lays the > difference. I wasn't looking that one of the check-ins that fixed the > bug - I was looking at the check-in that caused the bug, and it > referred me forward to issues that happened in the future. >
Here's an issue: https://github.com/facebook/zstd/issues/944 Here's the PR: https://github.com/facebook/zstd/pull/947 This isn't a particularity good example, because this isn't committed just yet, but you can see the reference to the bug/issue within the comment of the pull request. Here's a better one.... Issue: https://github.com/bitwarden/browser/issues/432 Commit to fix it: https://github.com/bitwarden/browser/commit/39eb015d3e7985eedaed438109f1098eeff23997 Within that commit, you can see the side-by-side diff, but you don't know when the original file was added/updated/etc. To find commits to that file, I think you pretty much need to do this: -Open a new browser tab -Go to the project -Navigate to the src file -See this: https://github.com/bitwarden/browser/blob/master/src/popup/app/vault/views/vaultViewCipher.html -Click history to see this: https://github.com/bitwarden/browser/commits/master/src/popup/app/vault/views/vaultViewCipher.html Opening a new browser tab may not be necessary if you know the src file path, but I wouldn't have known it. This whole process is much simpler in fossil... http://fossil-scm.org/index.html/info/421fe24138cd443b That's a commit, just click on the file name and you see this: http://fossil-scm.org/index.html/finfo?name=src/db.c&m=814414c831022a57 Very elegant. You can easily see things happened on different branches and you have various options to see changes: [annotate] [blame] [check-ins using] [diff] Not only that, but if you know the path to the file, then you can just change the URL: finfo?name=src/db.c That'll show you all changes to that file, regardless of the branch. I certainly don't need to sell you on this, though. ;) This probably isn't the best example of a github issue, though. I don't know of a project off-hand with multiple bug reports to the same code. > Maybe GitHub will do that? Do you have an example? > -- > D. Richard Hipp > [email protected] _______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
