On Tue, Mar 13, 2018 at 10:09 AM, Stephan Beal <[email protected]> wrote:
> On Tue, Mar 13, 2018 at 12:17 AM, João Batista <[email protected]> > wrote: > >> With fossil 2.5, it seems that "fossil json timeline checkin" does not >> show deleted files in a checkin, but "fossil timeline -t ci" does: >> ...So which is it? A bug? A "feature"? Or just a PEBCAK error...? :-) >> > > i _think_ what happened here is that at the time (late 2011) is that the > timeline page didn't list deleted files, and the json timeline simply > adopted that behaviour. i may be misremembering, but i can't conceive of > another reason i may have left that out. ... > More details... The JSON docs: https://docs.google.com/document/d/1fXViveNhDbiXgCuE7QDXQOKeFzf2qNUkBEgiUvoqFN4/view Say that each file's state is reported as one of the strings (modified, added, removed). A quick glance through the related code: https://www.fossil-scm.org/index.html/artifact/5a9ce59def16a55b?ln=353-354 and https://www.fossil-scm.org/index.html/artifact/6530c919e6671cbe?ln=282-288 suggests that it "looks okay". However, a quick local test also shows that a removed file is indeed not reported. The first suspect is the related query: https://www.fossil-scm.org/index.html/artifact/5a9ce59def16a55b?ln=323-332 i don't recall (it's been far too long) whether or not that catches deleted files, nor how to make it do so if it doesn't. Anyone wanting to look into it should start there, though. -- ----- stephan beal http://wanderinghorse.net/home/stephan/ "Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do." -- Bigby Wolf
_______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
