On 10/16/11 12:20, Stephan Beal wrote:
[---]
> Despite the slightly awkward layout for the really wide area (it's not your
> fault - just a side effect of being wide), i really like this. One tiny
> hint: the background color of the diff area should probably be explicitly
> set to white. Right now it is transparent, which causes the main content
> area's border to show through it. (That seems to be skin-dependent - skin
> "menu on the side" skin doesn't do this).

   I got your tip about that, but I only did it for the "rounded
corners" theme -- I just haven't gotten around to updating the others.

> Just in case you haven't tried it yet, i think you could add the
> wide-scrolling support with:
> 
> <...your container element... style='overflow:scroll'>...

   I played around with that, but it couldn't get it to do what I had
hoped it could; it just seemed to behave like "hidden", if I recall
correctly.

> see what looks good and what doesn't. If you select the built-in skin #4
>> (the one with rounded corners and gradients) and then go to the built-in
>> CSS editor, you'll find some "border-bottom"-properties which are
>> commented out.
> 
> i don't see those properties, and AFAIK skins are not synched via the
> checkin/checkout process (but rather with config push/pull). i think.

   I should have been clearer about refreshing the CSS: I've updated the
style.c and skins.c, so you need to reselect a skin from "Admin > Skins"
(and then refresh the cached files in your browser, etc).

   ... or copy, paste, and clean up one of the sbsdiff section from
style.c or skins.c.

>> long lines, while the built-in skin #4 does. Which one do you prefer?
> 
> Have you got two version numbers which show this? i can't find any (the vast
> majority of fossil's code wraps at 80 cols or less).

  The first diff of /ci/15de70c21f?sbs=1, left pane line 905, is what I
use for long line behavior testing.

-- 
Kind regards,
Jan Danielsson


Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to