On Wed, Nov 2, 2011 at 3:02 PM, Richard Hipp <d...@sqlite.org> wrote:
> On Wed, Nov 2, 2011 at 9:41 AM, Mark Janssen <mpc.jans...@gmail.com> wrote:
>>
>> Following patch fixes the issue.
>>
>
> This fixes viriketo's specific complaint, but it also creates a bunch of new
> problems for people running windows with non-UTF character sets.
>
>
>>
>> Index: src/blob.c
>> ==================================================================
>> --- src/blob.c
>> +++ src/blob.c
>> @@ -766,12 +766,11 @@
>> int blob_write_to_file(Blob *pBlob, const char *zFilename){
>> FILE *out;
>> int wrote;
>>
>> if( zFilename[0]==0 || (zFilename[0]=='-' && zFilename[1]==0) ){
>> - fossil_puts(blob_str(pBlob), 0);
>> - return blob_size(pBlob);
>> + return write(1, blob_str(pBlob) , blob_size(pBlob));
>> }else{
>> int i, nName;
>> char *zName, zBuf[1000];
>>
>> nName = strlen(zFilename);
>> _______________________________________________
>> fossil-users mailing list
>> fossil-users@lists.fossil-scm.org
>> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>
>
>
> --
> D. Richard Hipp
> d...@sqlite.org
>
> _______________________________________________
> fossil-users mailing list
> fossil-users@lists.fossil-scm.org
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>
>
Without wanting to open a huge can of worms, IMHO a DVCS should return
artifacts unmodified (e.g. treat everything as a binary file). In my
experience any automatic conversions are fragile and promote
sloppiness and it quickly leads to the mess of guessing if an artifact
is binary or text. If the encoding of a source file matters for
non-UTF windows users they should store the file in the encoding that
works for them or use ASCII only options to store non-ASCII chars
(\u....... for example).
Mark
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
