On Wed, 30 Jan 2013, Jan Nijtmans wrote: > 2013/1/30 Richard Hipp wrote: > > I'm uncomfortable with this change. If we need to use fossil_strcmp() > > everywhere (which surprises me, since strcmp() should *not* be subject to > > localization) then we should do so explicitly, and not depend on > > preprocessor magic, as the preprocessor magic will likely cause maintenance > > headaches down the road, and/or introduce subtle bugs such as the above. > > I'm open to other suggestions how to fix this. The problem was noticed on > 64-bit Ubuntu, it might be 64-bit specific (I'm not near that machine now). > I agree that it would be better to rename strcmp->fossil_strcmp everywhere, > but I don't think you want to do that in sqlite as well, therefore I came up > with the macro. AFAIS, fossil_strcmp() != strcmp()
http://fossil-scm.org/index.html/artifact/eda142ab1e3e0a0213d522c5b7a22831023cab0f?ln=898-902 # plain STRCMP (3) % for i in str{,n}cmp;do echo -n "$i - ";grep $i src/*.c|egrep -v "(sqlite3|fossil)_$i"|wc -l;done strcmp - 143 strncmp - 210 I would undo "magic" and rename nothing :-) Sergei _______________________________________________ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
