Thus said Jan Nijtmans on Fri, 01 Nov 2013 16:53:24 +0100: [Be aware that I have only been looking at the Fossil code for a short time, so what I say may be inaccurate]
> 1) If a password is necessary and there is a saved password, use > the saved password. > 2) Otherwise, prompt for a password. > 3) Do the actual clone/sync/.... > 4) If the clone/sync/... did not succeed because of an > authentication problem, go to step 2). Only repeat this a certain > number of times. I believe steps 1--4 are fine and do work as expected. Due to the way the http sync code is written, I don't know how many times we can actually continue to prompt after a failure. At the moment, if the password fails---whether stored or provided---there is only one additional attempt allowed before the entire operation fails. (I don't actually see a problem with this). > 5) If the clone/sync/... succeeded and a password was used which > is different from the saved password, and no --once option is > given, prompt whether the password should be saved. This would seem to be new behavior that does not, as of yet, exist in Fossil. At the moment, the password is saved regardless of the success/fail status of the sync operation (except when --once is in force). > Currently, the password is saved before doing the clone/sync/... , but > I think it should only be saved afterwards when the operation > succeeds: If it fails the user should be given a chance to correct the > password. And if the operation is aborted, the previously saved > password should still be there. This looks fine and is probably more correct behavior in the long term. If we want to go this route now, we can morph the changes that I've been making into changes for this newer behavior; in which case I think I would like to move the changes out of pending-review and into a new branch to work on them there. Otherwise, we can merge the current changes---which are complete as far as I can tell with respect to the originally reported problem---and begin a new branch to address the problem of saving the password only *after* the sync has succeeded. Thoughts? Andy -- TAI64 timestamp: 4000000052749d4b _______________________________________________ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
