2015-04-19 2:06 GMT+02:00 Andy Bradford <amb-fos...@bradfords.org>:
> The only time that  fork detection makes sense (if at  all) is *after* a
> complete sync in the client.

Just repeated my earlier experiment using "sync-forkwarn" branch, and got:
    $ time ./fossil pull -R z.fossil http://www.fossil-scm.org/index.html
    Round-trips: 209   Artifacts sent: 0  received: 17734
    Pull done, sent: 761275  received: 10502627  ip: 67.18.92.124
    ***** WARNING: a fork has occurred ***** use "fossil forks" for
more details.
Hey, the self-hosting fossil repository doesn't contain forks any more,
how is this possible?

Explanation: the current code in "sync-forkwarn" doesn't do the fork-check
at the end of the sync, it does it at the end of each round-trip. Since there
were some forks created long ago which were only recently closed, this
can result in a false warning: Maybe the artifacts in a round-trip create
a fork, but this fork is resolved in some future round-trip which is still
part of the same sync operation.

It seems it's not wise at this moment to merge "sync-forkwarn" to trunk
since false warnings here may be more confusing than that they help :-(

Regards,
       Jan Nijtmans
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to