On Jan 31, 2016, at 7:08 AM, Ron Aaron <[email protected]> wrote: > > It used to be the case that clicking on the header of a ticket report would > sort according to the column clicked. That seems to not work now. > > I verified it also doesn't work on the fossil site, so it's not just my > misconfiguration…
I bisected it and discovered that the problem was introduced on December 5 in checkin f98264231599088. On investigating, the problem is that the call to output_table_sorting_javascript() in src/report.c is passed an empty string for the zColumnTypes parameter, which is *supposed* to mean “all columns sort as text” according to the function comment, but which actually means “no columns are sortable” since this change which optimizes out unused sorting types in the generated Javascript. The attached patch restores the behavior contract in the function comment. In effect, a 6-column report gets created as if you’d passed “tttttt” for the zColumnTypes parameter. If all-text sorting isn’t the right thing, the call to output_table_sorting_javascript() needs to grovel through the SQLite column type data to generate the correct values for this parameter.
fossil-report-sorting.patch
Description: Binary data
_______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
