2016-06-10 10:12 GMT+02:00 Scott Robison: > FYI, my test code here (C++ harness) consisted of passing every possible > four byte buffer to the old function and my new function. My function > identifies the expected number of "strings" as valid UTF-8. I didn't eyeball > each one to make sure the right ones got through, but getting the exact > right number is promising to me. > > Let me know if you see anything horridly wrong with my code. It's 2am...
It turns out that your code appears fine, it's just less efficient than mine ;-) There were test-failures but all failures turned out to be errors in the expected test-outcome. I fixed those test-cases now, added more of them, and fixed the invalid_utf8() function in trunk. Now all tests pass with both trunk code and your code. Many thanks, Scott ! Once more, fossil got better than it was! Regards, Jan Nijtmans _______________________________________________ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users