On 9/7/2016 1:15 AM, Jan Nijtmans wrote:
....
Would this be enough reason to do a quick 1.35.1 release? Two
regressions are already found plaguing 1.35 for situations
which worked fine in 1.34. Branch "branch-1.35" is ready,
the only thing missing there is updating changelog.wiki.

I built and tested branch-1.35 with MinGW and MSYS on Windows 10 Pro using the zlib from the tree with and without SSL support. Exactly two test cases report failures: merge-utf-79-23 and merge-utf-79-32. Nearly all released versions of fossil I've examined have a similar pair of failed test cases.

So my testing does not block releasing 1.35.1.

I have no strong opinion about whether such an update is required, but the most recent regression does seem like it causes real problems if tripped over.

On the pair of failed tests: nearly all released versions of fossil have failed a trial of the merge-utf-*-{23,32} cases. This is a family of merge tests built using source files drawn from the fossil test suite itself, which are hammered with random edits, merged, and validated. The use of the random number generator fuzzes through a lot of cases. Today's failure is the 79th fuzzing of utf.test. I strongly suspect that this exposes an edge case in the merge logic when dealing with (likely) broken UTF characters in one or more of the changes being merged.

Figuring out what is really going on there has been on my back burner for a while now, I may have to give in to curiosity (despite what that does to cats) and try to understand it one of these days.

--
Ross Berteig                               r...@cheshireeng.com
Cheshire Engineering Corp.           http://www.CheshireEng.com/
+1 626 303 1602
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to