I don't see why Fossil cares if there is an open checkout for editing a
comment interactively -- create a temporary file in the normal way that
temporary files are normally created (TMPDIR et. al.) and allow the user
to edit it, then consume the new contents.
Why is the check-out directory considered at all ?
On Thu, 25 May 2017, Andy Bradford wrote:
Thus said Roy Keene on Thu, 25 May 2017 21:17:15 -0500:
Given that this worked, why was it broken ? And can the error message
be converted to something that is actually coherent ? And can it be
unbroken ?
Apparently it was broken intentionally because there was a segfault that
happened when using ``fossil amend -R repo.fossil -e'' outside an open
checkout:
http://marc.info/?t=148979529000002&r=1&w=2
Is there a reason why one shouldn't be able to use amend outside an open
check-out? One alternative would be to simply disallow interactive edits
outside an open checkout:
http://www.fossil-scm.org/index.html/info/afef5fb5fc49fdd9
However, perhaps this could be improved by detecting whether there is an
open check-out here:
http://www.fossil-scm.org/index.html/artifact?ln=1209-1210&name=237694d101bab9bc
And if there is no open check-out use unixTempFileDir to locate a
suitable location and put the file there?
Or maybe file_relative_name should actually try to handle a NULL file
path and simply treat that as ``current working directory'' and make it
relative to . rather than fail?
Thoughts?
Andy
--
TAI64 timestamp: 400000005927a824
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
