Am 21.11.2016 um 02:54 schrieb Paul Ishenin: > 21.11.2016 8:16, Maciej Izak wrote: > > Overall you've made a great job and a perfect example of how to supply > patches for FPC. > > I have a small question regards the following commit: >> 13. >> https://github.com/maciej-izak/freepascal/commit/9baa32a49a204686427981d33c9054f64b2057c4 > > Use fpc_Copy for Clone and fpc_Addref for Copy is misleading.
Copy is only equal to addref in case of arc types. If a type is only managed like a variant, copy is not an addref operation. So it should not be called addref. As fpc_addref is not exposed to users I think we can handle this. > > I know Florian insisted on Copy and Clone names but still for my taste it > would be the best to have > conformity between compiler and RTL. _______________________________________________ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel
