The inc()s were needed due to alignment issues with the previous RTTI
implementation !
I indeed also wish for them to be not necessary anymore.
------ Origineel bericht ------
Van: "Sven Barth" <pascaldra...@googlemail.com>
Aan: "FPC developers' list" <fpc-devel@lists.freepascal.org>
Verzonden: 31-1-2017 14:56:19
Onderwerp: Re: [fpc-devel] Patch #31249 and objects
Am 31.01.2017 12:37 schrieb "Maciej Izak" <hnb.c...@gmail.com>:
>
> Hi,
>
> Somehow my patch #31249 was ignored. Could someone from core team
look at :
>
> http://bugs.freepascal.org/view.php?id=31249
> http://bugs.freepascal.org/view.php?id=31305
>
> patch and reported bug is very important. I can't update mORMot for
newest FPC RTTI without changing all objects to records (which is
possible in this case but still we have serious bug)... -,-.
I "ignored" it, cause up to now it was merely a performance
improvement. If you had added your info from 31305 to 31249 instead of
creating a new report then I might have reacted faster.
Anyway, I'll try to get it applied tonight.
PS: If you adjust mORMot then I highly suggest you not to use custom
records/objects, but the typinfo ones as much as possible as they deal
with alignment issues correctly (especially the new types of the
interface RTTI). Or at least use the typinfo types to retrieve pointers
to the correct parts of the RTTI and store those instead of using
inc()s to navigate the RTTI.
Regards,
Sven
_______________________________________________
fpc-devel maillist - fpc-devel@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel
