--On January 10, 2012 10:11:15 PM +0100 Alexander Leidinger
<alexan...@leidinger.net> wrote:
On Mon, 09 Jan 2012 15:55:48 +1000 Da Rock
<freebsd-po...@herveybayaustralia.com.au> wrote:
Now my Makefile looks like this:
# New ports collection makefile for: linux-f10-nss_ldap
# Date created: 2012-01-04
# Whom: da porta
port_maintai...@herveybayaustralia.com.au
#
# $FreeBSD$
#
PORTNAME= nss_ldap
PORTVERSION= 0.01
The PORTVERSION looks a little bit off to me. I would use something
like ${NSS_LDAP_VERSION} or ${NSS_LDAP_VERSION}.${RPMVERSION} (the
later may look a little bit strange... or not) to make it easy to
compare what is installed on a system with what is available on linux.
CATEGORIES= net linux
MASTER_SITES=
ftp://ftp.pbone.net/mirror/archive.fedoraproject.org/fedora/linux/update
s/testing/10/i386/ \
http://archives.fedoraproject.org/pub/archive/fedora/linux/releases/10/E
verything/i386/os/Packages/ \
http://herveybayaustralia.com.au/ports/distfiles/
I can't remember if we have the fedora archives in bsd.sites.mk (if
not, it would be worth to add it), and I'm too lazy ATM to search for
it. If we have them (and they are OK), it would be better to use the
bsd.sites.mk shortcodes for them. This would change automatically the
master sites for this port if they are changed/improved in bsd.sites.mk.
Too lazy to do this?
# grep FEDORA /usr/ports/Mk/bsd.*
/usr/ports/Mk/bsd.linux-rpm.mk:MASTER_SITES=
${MASTER_SITE_FEDORA_LINUX}
/usr/ports/Mk/bsd.sites.mk:.if !defined(IGNORE_MASTER_SITE_FEDORA_LINUX)
/usr/ports/Mk/bsd.sites.mk:MASTER_SITE_FEDORA_LINUX+= \
PKGNAMEPREFIX= linux-f10-
DISTNAME= ${PORTNAME}-${NSS_LDAP_VERSION}-${RPMVERSION}
MAINTAINER= port_maintai...@herveybayaustralia.com.au
COMMENT= RFC 2307 NSS Module (Linux Fedora 10)
LICENSE= GPLv2
NSS_LDAP_VERSION=264
USE_LINUX_RPM= yes
USE_LINUX_PREFIX=yes
Hmmm... I would expect that USE_LINUX_RPM automatically sets
USE_LINUX_PREFIX... to be verified.
USE_LINUX_RPM implies the inclusion of bsd.linux-rpm.mk. bsd.linux-rpm.mk
includes USE_LINUX= yes and USE_LINUX_PREFIX= yes. So putting
USE_LINUX_PREFIX in the Makefile is redundant.
--
Paul Schmehl, Senior Infosec Analyst
As if it wasn't already obvious, my opinions
are my own and not those of my employer.
*******************************************
"It is as useless to argue with those who have
renounced the use of reason as to administer
medication to the dead." Thomas Jefferson
"There are some ideas so wrong that only a very
intelligent person could believe in them." George Orwell
_______________________________________________
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
