Hi!
19-Июн-2004 15:41 [EMAIL PROTECTED] (Kenneth J. Davis) wrote to
[EMAIL PROTECTED]:
>> I may send you my edition of config.c (private, I suggest?), but it not
KJD> please do
Done. See archive with config.c, portab.h (from which used new macro)
and makefiles (which also pass for compiler path to its include files - new
portab.h uses compiler's limits.h).
KJD> are strictly changes to comments. When I apply your dsk.c patch 10,
KJD> which does change the prototypes, I will change floppy.asm to match.
Why change prototype lines twice? As I understand, this generates extra
unnecessary entries in CVS.
>> this is no so. Also, I think, explaining in comments for "sbb al,al" that
>> "Al=-CF" is not good. This is same, as write next:
>> int i = ...
>> i++; /* increment i */
KJD> My comment isn't AL=-CF it is AL=-CF={-1,0}, the comment is
KJD> saying that after the sbb call, AL is either -1 or 0.
But this is what "sbb al,al" mean and do. I think, comment should
contain more "high-level" explanations, than repeating description from
Instruction Set Manual. For example:
sbb al,al ; CF=0 (disk has not changed)
jnc ret_AH_0 ; ...return 0
cmp ah,6 ; ah!=6 (error)
jne ret_AH_0 ; ...return 0xFF
>> (BTW, you preserve comment in "mov ah,0 ; zero out ah"). Also, you preserve
KJD> sure its an obvious comment, but how does it adversely effect anything?
It not affect anything, but this comment was not present in my patch.
This mean, you copy it from old source.
>> comment, because there is code for "format" and "verify" (same for
KJD> how about 'count of sectors to read/write/...'
What bad in plain "number of sectors"?
>> fl_lba_readwrite()). Also, you remain "(Zero transfer count)" and "force
>> into < 255 count", whereas AL (AL only, AH cleared!) returns error code, not
>> "transfer count".
KJD> ok, adjusted, I read this comment as extending al into ax without sign
KJD> extension.
Ok.
>> PPS: Also, there are cosmetic remarks (from me :): in some places you
>> preserve my tabulations (though, before some comments you lost one - see,
>> for example, "mov ah,18h"), in other places you preserve trailing spaces
>> (even on empty lines)...
KJD> While I will commit some, I prefer to not make whitespace only changes.
KJD> it also depends on how I apply a given patch.
When you change line, this is wise to fix, for example, spacings. But
your changes are inconsistent: in one case you preserve spaces, in other
case you replace spaces by tabs, in third case I see wrong shifting:
______________O\_/_________________________________\_/O______________
mov al, 1 ; set change occurred
fl_dc: cbw ; extend AL into AX, AX={1,0,-1}
ret ; note: AH=0 on no change, AL set above
[...]
push bx ; restore stack
mov ah,17h ; floppy set disk type for format
_____________________________________________________________________
O/~\ /~\O
-------------------------------------------------------
This SF.Net email is sponsored by The 2004 JavaOne(SM) Conference
Learn from the experts at JavaOne(SM), Sun's Worldwide Java Developer
Conference, June 28 - July 1 at the Moscone Center in San Francisco, CA
REGISTER AND SAVE! http://java.sun.com/javaone/sf Priority Code NWMGYKND
_______________________________________________
Freedos-kernel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/freedos-kernel
