Thomas Adam <tho...@xteddy.org> writes:
> On Tue, Dec 28, 2010 at 11:20:30AM -0500, des...@verizon.net wrote:
>> Go ahead. I checked in what I have.
>> I'll lay off for a few days.
>
> Well, I've made a lot of changes -- I'd be grateful if you'd have a look and
> ensure I've not botched any CVS conflicts which I had to resolve -- it seems
> to work for me, but I might not be testing the same areas as you.
I found the easiest way to resolve conflicts is first determine if I
liked the committed code. If so, just delete the whole block.
Then update again.
>> The cleanups are nice.
>> I have a bunch of basic function issues which I've listed at the
>> front of the file.
>
> I'll get to those in a bit. I am more interested in cleaning up what's
> currently there, as a lot of the inherited xdg-menu code from the SuSE
> people is nothing short of abysmal to be frank.
>
> However, the things to take away from my latest commit are:
>
> * Reindented the entire file by hand (because Vim did a piss-poor job) so
> that the following "rules" hold true:
>
> - Braces are on a line of their own for all block construct, so for
> instance:
Yeah, well, I don't like that, but others do so I guess I have no
choice. I'm outvoted it seems.
It seems to me pretty dumb to waste vertical space like that.
> if (...)
> {
> } else {
> }
>
> Should be written as:
>
> if (...)
> {
> }
> else
> {
> }
Yep, 3 lines:
if (...) {
} else {
}
to 6, but I'm pretty lonely in my camp.
Seems other people like to see things "line up",
but they don't line up to me.
Anyway, if you download perltidy and give it the right
options, it's deal with most of that.
> * In-line logic conditions (if/unless, etc) like this:
>
> foo($bar) unless $baz;
Lots of that, and I think it's all backwards.
if ( ! $baz ) {
foo($bar);
}
> Now I'll concentrate on removing the hideous amount of duplication we have
> between subroutines, refactoring those, and making the code less unwieldy.
> :)
Go for it and don't pay attention to my rants about style.
I have my preferences but I'll live with majority opinion.
