Hi.

What do you think of separating the compatibility code (replacement
functions) from libfvwm?

Functions like strncasecmp or strdup are spread all over the code. For
systems that do not have them availiable, libfvwm is responsible for
providing them. But the question is, should this be the responsibility
of libfvwm? Or should fvwmlib have only fvwm related functions and
leave the system compatibility functions to another lib?

What I think:

Compatibility functions should be separated from libfvwm, as they "are
not part" of fvwm. They should be linked automatically if needed, but
should remain invisible for the libfvwm code. Particulary, the
replacement function definitions should be in config.h if needed,
instead of fvwmlib.h. It would help on keeping the code clean, as the
replacement functions should be stable now, and may even be kept "as
is" to fvwm3.0 (?).

I believe (supported by local tests) that this is possible to do
without too much fuss or without introducing any bugs.

On the other hand, it may be prudent to wait before the 2.5.17 release.

I'm waiting for opinions..
Cheers,
 Renato

Reply via email to