On Thu, Feb 09, 2006 at 04:28:38AM +0000, Mikhael Goikhman wrote: > On 08 Feb 2006 20:54:26 -0500, Peter Williams wrote: > > > > According to FvwmDebug, there are no configure_window messages posted > > to the modules that FvwmPager could latch on to in order to detect > > when a window backcolor changes. The only messages sent to the modules > > in my case (restyling as a result of a window name change) are > > m_visible_name, m_icon_name, and m_window_name. > > > > FvwmPager could check for backcolor when it receives one of those but > > that seems kind of silly... alternatively fvwm could brodcast an > > m_configure_window message to the modules whenever a window style > > changes. > > > > Does that sound reasonable? > > Theoretically this is correct (every change in M_CONFIGURE_WINDOW values > should be reported in one or another way). Practically this will make > this packet even more floody. > > M_CONFIGURE_WINDOW and M_FOCUS_CHANGE should be redesigned. I am not sure > sending fore_color and back_color to the modules is a good idea. I would > send a window colorset number instead. The colorsets are the way to go, > some pager options (like Window3DBorders) only work with colorsets. > > I think the correct things to do in the future is to alter the content of > M_CONFIGURE_WINDOW as I described, send it on every "Style Colorset", and > alter the pager to support colorsets per window (i.e. use the colorset > number sent in the packet, unless global WindowColorsets is defined).
Just what I am thinking. I may get around taking a look at the code in the next couple of days. > I see no good reason to support "Style BackColor", since it is scheduled > to be removed in the future. Colorsets should be used instead. Right. I'm not going to write any fixes to the old options. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED]
signature.asc
Description: Digital signature
