>>> On 3/13/2008 at 6:24 PM, in message <[EMAIL PROTECTED]>, Carlo Marcelo Arenas Belon <[EMAIL PROTECTED]> wrote: > On Thu, Mar 13, 2008 at 11:39:48AM -0600, Brad Nicholes wrote: >> I think I have everything working now using your patches. > > got a fair number of conflicts when merging them back with the most > interesting ones being : > > 1) I rearranged some of the values for GCFLAGS/GLDADD/GLDFLAGS out of the if > STATIC_BUILD because they were the same in both branches. presume you would > rather have them explicitly duplicated for code clarity purposes?. I was > considering that in the long run the only difference should be with GLDFLAGS > having "-static" or something simpler than that replacing all them but I am > ok > with whatever intermediate step makes more sense for now; but wanted to be > sure that there were no merge errors as for example the current > gmond/libganglia Makefiles seem to have only the APR headers included when > --enable-static-build is not used and so if the apr library is installed in > /usr and --with-libapr is not used it will break. >
The conflicts are probably because I lied ;) I used your patches for removing expat (which you already committed) and libconfuse. By the time you sent the libapr removal patches, I had already done the work and it basically matches your patch. So rather than start over again and then reapply your libapr patch, I just checked in what I had. Please feel free to fix up anything that I might have missed. Especially when it comes to libapr removal. > 2) why are we recommending installing libapr from source in cygwin when > there > is an apr1 package that could be installed instead?, does that somehow fix > the > broken module symbols that prevent gmond to start in cygwin? > Not sure. I didn't change anything with regards to cygwin. If I did, I didn't mean to. >> I am just doing some final testing before checking everything in and > removing /srclib completely. > > what checks did you run?, the patches I provided passed (with and without > --enable-static-build) > The checks that I ran were just to make sure that changing the options for configure really did what it is expected to do. In other words, with or without --enable-static-build, with or without the various --with-libXXX options. > 1) gentoo linux amd64 with all dependencies installed from portage > 2) windows vista premium x86 will all dependencies installed from cygwin > except > for libconfuse that was build from sources and therefore required the use of > --with-libconfuse (tested installed in /usr/local and uninstalled) > > they all build fine (except from some noisy warning because I was not using > --enable-status), but cygwin wasn't able to run gmond (not a regression, as > it has been there since the modular metrics AFAIK) > > Carlo ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Ganglia-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ganglia-developers
