>>> On 3/31/2008 at 9:48 PM, in message <[EMAIL PROTECTED]>, Carlo Marcelo Arenas Belon <[EMAIL PROTECTED]> wrote: > On Mon, Mar 31, 2008 at 06:31:46PM -0600, Brad Nicholes wrote: >> >> I have checked in the code that removes APR from all of the public header > files except for gm_metric.h which is needed by the modules. Everything else > should be APR-free. This includes libmetrics, gmetric, gmetad, gstat and > gexec. They may still be indirectly using APR through libganglia, but the > apr headers aren't required to build them. > > nice work, any reason why gm_metric.h doesn't include ganglia.h instead of > including only the pieces? > > Index: gm_metric.h > =================================================================== > --- gm_metric.h (revision 1177) > +++ gm_metric.h (working copy) > @@ -1,11 +1,9 @@ > #ifndef GM_METRIC_H > #define GM_METRIC_H 1 > -#include <rpc/rpc.h> > > #include "gm_mmn.h" > -#include "gm_protocol.h" > #include "gm_value.h" > -#include "gm_msg.h" > +#include "ganglia.h" > > #include <confuse.h> /* header for libconfuse */ > #include <apr.h>
No real technical reason just a separation of technology. The way things kind of fell out was that ganglia.h would be included by utility type applications such as gmetric, gstat, etc. that need the interfaces to libganglia. Metric modules would include gm_metric.h to get just the metric module related stuff. Metric modules don't really need all of the libganglia prototypes. Brad ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Ganglia-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ganglia-developers
