On Tue, Apr 01, 2008 at 04:44:26PM -0700, Bernard Li wrote:
> 
> Carlo, it looks like r1179 broke configure for me:
> 
> http://ganglia.svn.sourceforge.net/viewvc/ganglia/trunk/monitor-core/configure.in?r1=1179&r2=1178&pathrev=1179
> 
> This results in passing "-L" with no arguments:

Committed revision 1191.

> Also, in the following code snippet:
> 
>   1064    carenas   if test -f "$libaprpath" ; then
>   1064    carenas     APR_INCLUDES=`$libaprpath --includes`
>   1064    carenas     AC_SUBST(APR_INCLUDES)
>   1072    carenas     APR_LIBPATH=`$libaprpath --link-ld`
>   1072    carenas     LDFLAGS="$LDFLAGS -L`expr "x$APR_LIBPATH" :
> '.*-L\(.*\) '`"
>   1168    carenas     AC_CHECK_LIB(apr-1,
> apr_socket_send,,,[`$libaprpath --libs`])
>   1064    carenas   else
>   1064    carenas     CFLAGS="$CFLAGS -I$libaprpath/include"
>   1064    carenas     LDFLAGS="$LDFLAGS -L$libaprpath/lib"
>   1064    carenas     echo "Added -I$libaprpath/include to CFLAGS"
>   1065    carenas     echo "Added -L$libaprpath/lib to LDFLAGS"
>   1168    carenas     AC_CHECK_LIB(apr-1, apr_socket_send)
>   1064    carenas   fi
> 
> I think you meant to put down "$libaprpath/apr-1-config --includes", etc.

no, the first path is used when --with-libapr points to the location of
apr-1-config (as used in Apache --with-apr) and so the syntax is correct (even
if I agree looks confusing and needs refactoring).

are there any valid uses of --with-libapr where it points to a directory with
"include" and "lib" subdirectories?

Carlo

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Ganglia-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ganglia-developers

Reply via email to