On Sat, 2009-01-10 at 11:25 +0000, Carlo Marcelo Arenas Belon wrote: > On Thu, Jan 08, 2009 at 04:13:13PM -0500, Jason A. Smith wrote: > > > > Recently I started testing the svn version of the web scripts and found > > a few bugs. > > could you elaborate on the bug this patch is fixing?, the code from > trunk and the other 2 active branches seems similar enough to consider > this a problem also outside of trunk.
I have not tested nor looked at any other trunks unfortunately. I have a working 3.0.7 installation, and this problem does not exist there. Besides that stable version, I have only been testing the version in the svn trunk. > > Fixed graph zooming and make sure the default summary graph size > > overrides the size selected for the cluster graphs. > > "graphargs" should contain (in the host view) all host specific parameters > that are needed to create the graphs like h (hostname), r (range) and > st (start time) but doesn't have z (size) and therefore by moving it to the > beginning of the generated URL all it changed is the order used, at > least for the report graphs which are the ones that are being patched. The problem I noticed was mainly in the cluster view, when selecting a specific metric to look at or the size, it would also change the size of the top summary graphs in addition to the lower host graphs. I assume this is an unintended consequence of probably a few patches interacting together since previous versions of ganglia did not do this, but I did not bother to track it down. I think the problem also occurred in the host view, but I don't really remember. The meta view already had the graph variable placed first in the arg list, so patching in this way also makes all three main graph views work the same. The only change, as you say is the order of the "graphargs" to force the medium size to override what is in the variable. > for the metrics graph, the order does (sadly) make a difference as the > zoom relies on having "z" redefined to "large" through the template, but > the patch doesn't apply to that section of the code. I am not sure what you mean here, the patch does apply to the "zoom" feature, since it does touch the graph image links also. In addition to the summary graphs at the top being affected, I noticed that zooming was also broken. > could we instead remove the hardcoded values and manage the URLs in a > way that makes them not dependent on the order of the parameters so that > variables are overriden? Possibly, this was just the easiest fix that I thought of though, since it keeps the graph args variable in the list, so they can share things like the time range, so they don't have to be managed separately, just the order was changed, to act like an override. ~Jason -- /------------------------------------------------------------------\ | Jason A. Smith Email: [email protected] | | Atlas Computing Facility, Bldg. 510M Phone: +1-631-344-4226 | | Brookhaven National Lab, P.O. Box 5000 Fax: +1-631-344-7616 | | Upton, NY 11973-5000, U.S.A. | \------------------------------------------------------------------/
smime.p7s
Description: S/MIME cryptographic signature
------------------------------------------------------------------------------ Check out the new SourceForge.net Marketplace. It is the best place to buy or sell services for just about anything Open Source. http://p.sf.net/sfu/Xq1LFB
_______________________________________________ Ganglia-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ganglia-developers
