Brooks Davis wrote:
> On Sun, Feb 07, 2010 at 01:30:43PM +0000, Daniel Pocock wrote:
>
>> We've just been discussing the sysconfdir issue while here at FOSDEM
>>
>> For Ganglia <= 3.1.2,
>> - the configure --help output tells people they can use --sysconfdir to
>> set the location of gmond.conf
>> - the configure --help output tells people that the default is PREFIX/etc
>> - the value of --sysconfdir passed to configure was ignored however, and
>> everything goes to /etc/ganglia (or /etc for < 3.1.0)
>>
>
> This has annoyed me for ages, I'm glad progress is finally being made.
>
Yes, and I have never claimed it is the complete solution, just an
improvement in the right direction
>
>> Looking at what a user might do and how configure should behave:
>>
>> ./configure --prefix=/opt/ganglia
>>
>> In this case, the user would expect gmond.conf to be in
>> /opt/ganglia/etc/gmond.conf, and conf.d will be in /opt/ganglia/etc/conf.d
>>
>> ./configure --prefix=/usr/local
>>
>> - the user would expect gmond.conf to be in /usr/local/etc/gmond.conf
>> - however, a new problem arises because conf.d will be
>> /usr/local/etc/conf.d - not a good idea
>> - therefore, for --prefix=/usr/local, the user would probably have to
>> set sysconfdir and prefix:
>>
>> ./configure --prefix=/usr/local --sysconfdir='/usr/local/etc/ganglia'
>>
>> or, to be more precise, the user may want to use this syntax instead:
>>
>> ./configure --prefix=/usr/local --sysconfdir='${prefix}/etc/ganglia'
>>
>> I have implemented support for sysconfdir in such a way that this syntax
>> will work. I realise this may surprise people, and those who have
>> written packaging scripts will need to add something like this to their
>> script.
>>
>
> IMO this isn't enough of a solution. First, conf.d isn't adequately
> descriptive even when it's in a ganglia directory because the files
> actually only apply to to gmond. Second, I continue to believe that
>
I agree with that - but we should stick with it for 3.1.x, and maybe
make this a key fix for 3.2.0
> having the ganglia directory at all has never made sense. Historically
> we've had exactly two, well defined config files so I've never seen a
> compelling need for a ganglia directory. On the FreeBSD port we just
> have gmond.conf and gmetad.conf that live in ${prefix}/etc. I propose
> that we rename conf.d to gmond.conf.d.
>
That is a feasible solution, but I would propose going further with a
flexible solution - something that allows the user to call it whatever
they like.
It is not particularly hard to fix, not particularly trivial either, but
basically the references to conf.d are spread out across the spec files,
the source code and the example files. The same goes for some other
path related issues (e.g. the module locations)
> Also, when I was looking, it appears that ${sysconfdir}/conf.d is
> hard coded. It seems to me that we'd be better served by a config
> include directive similar to the one in Apache.
>
Yes, I feel that is a good improvement over coding in the value
`/etc/ganglia/conf.d' - but I agree we can go further.
Maybe we should do the following:
- minimum possible changes to release 3.1.7
- branch monitor-core-3.1 to create monitor-core-3.2 - in other words,
3.2.0 will be the next release after 3.1.7, rather than 3.1.8
- remove the GANGLIA_ACK_SYSCONFDIR stuff (i.e. no longer make any
attempt to warn users about this substantial fix when they run configure)
- fix all the other path issues in configure and the spec file
- release 3.2.0
------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
_______________________________________________
Ganglia-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ganglia-developers
