On Mon, Dec 17, 2007 at 10:34:19PM -0500, Jesse Becker wrote: > This is a minor patch for get_context.php. It mostly cleans up the > large block of checks, and also puts an isset() in front of all > variables used as array indexes.
and is doing rawurldecode for several other variables (hc, sh, p, t, jr, js, w, z) that didn't have it before because of the use of a common function for all of them. if that is ok and expected, why isn't the function doing the "isset" check and returning NULL if it returns false instead so that the code would be cleaner to read and all checks are done in a single place? Carlo disclaimer: I didn't look at the functionality of the PHP page, only at the logic behind the script and the changes that were applied because it was touching the logic that was put in place recently for the XSS security fix and the changes didn't seem that minor considering line count and that there were not only made up syntactic changes as it seemed to be implied by the description. ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Ganglia-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ganglia-developers
