On Wed, Jul 02, 2008 at 10:57:17AM +0100, [EMAIL PROTECTED] wrote: > I've just been looking at mod_multicpu.c > > I notice a lot of code is required for converting the metric name string > to an individual CPU number, and deciding which metric function to > invoke.
are you referring to get_metric_name_cpu that decodes the metric name?, why is that a lot of code? > It would seem much simpler to have this data in the Ganglia_25metric > type, by adding some kind of private pointer: an opaque pointer to save some extra data seems like a good idea, but will cost at least 8 bytes more per metric. for this specific use case, it might not be a good idea as it will be redundant with the metric name (one set of data can be derived from the other) but if you think there will be any significant performance advantage on doing so then show us the numbers ;) Carlo ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
