https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80759
--- Comment #29 from Daniel Santos <daniel.santos at pobox dot com> --- (In reply to r...@cebitec.uni-bielefeld.de from comment #28) > As I've said before, the parallelization of ms-sysv.exp runs may be a > bonus, but is certainly separate from this PR and thus should be split > out: Yes, you are right of course. I was trying to kill too many birds with one stone and I somehow omitted a bit of your patch for the function size thing, sorry about that. Some of this gets complicated though, if you want me to use dg-runtest then a few other changes must be made as well, but obviously not as many as I had included. I'll get this sorted out. Please also note that I did seek guidance when putting this exp file together (back in December) I was following Mike Stump's direction, but you were probably on vacation or something. :) https://gcc.gnu.org/ml/gcc/2016-12/msg00145.html I've also been motivated to expand the tests by a change somebody else made to my original patch that I wasn't confident the original tests would fully check (been worried about it, but it all looks good). I'll get a cleaned up patch for you soon. (In reply to r...@cebitec.uni-bielefeld.de from comment #27) > * Also as I'd reported before, with the fix above, I still get a couple > of FAILures: > > > FAIL: gcc.target/x86_64/abi/ms-sysv/ms-sysv.c -O2 "-DGEN_ARGS=-p0\ -t64" > (test for excess errors) > Excess errors: > /var/gcc/regression/trunk/12-gcc/build/gcc/testsuite/gcc/ms-sysv/ms-sysv- > generated.h:30:1: error: bp cannot be used in asm here > > Full compiler output is > > In file included from > /vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/ms- > sysv.c:158:0: > /var/gcc/regression/trunk/12-gcc/build/gcc/testsuite/gcc/ms-sysv/ms-sysv- > generated.h: In function 'msabi_02_0': > /var/gcc/regression/trunk/12-gcc/build/gcc/testsuite/gcc/ms-sysv/ms-sysv- > generated.h:30:1: error: bp cannot be used in asm here > > At least some of the tests PASS now :-) Well this is a problem and is unexpected. Can you please post the relevant portion of the log file? What I really need to see is the command line to build ms-sysv.c. I'm going to *guess* that the problem is that TEST_ALWAYS_FLAGS contains something that enables hard frame pointers and that I need this little change: # Detect when hard frame pointers are enabled (or required) so we know not # to generate bp clobbers. - if [regexp "^(.+ +| *)-(O0|fno-omit-frame-pointer|p|pg)( +.*)?$" \ - $cflags match] then { + if [regexp "^( *|.* )-(O0|fno-omit-frame-pointer|p|pg)( *| +.*)$" \ + "$TEST_ALWAYS_FLAGS $cflags" match] then { set generator_args "$generator_args --omit-rbp-clobbers" } We could also just pass --omit-rbp-clobbers to the generator in all cases, although it would weaken the tests. Thanks, Daniel
