https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80759

--- Comment #55 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot 
Uni-Bielefeld.DE> ---
> --- Comment #54 from Daniel Santos <daniel.santos at pobox dot com> ---
> Created attachment 41627
>   --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=41627&action=edit
> darwin fixup (on top of v6) -- second attempt
[...]
> The macro has only two uses, so if you prefer, I can remove it and just 
> replace
> it with inline #if blocks, e.g.,
>
> #ifdef __MACH__
>         "       mov     " ASMNAME(test_data) "@GOTPCREL(%%rip), %%rax\n"
> #else
>         "       lea     " ASMNAME(test_data) "(%%rip), %%rax\n"
> #endif

I'm fine either way, with a slight preference for the macro version (the
less code duplication, the better ;-)

I've tested this patch last night on both x86_64-apple-darwin11.4.2 and
i386-pc-solaris2.12 and it worked just fine on both!

Thanks a lot.

        Rainer

Reply via email to