This discussion continues in the thread "[patch] Split Parse Timevar (rev 2) (issue4433076)" which has a new uploaded patch.
On 4/23/11, Jason Merrill <ja...@redhat.com> wrote: > On 04/22/2011 06:41 PM, Lawrence Crowl wrote: >> On 4/21/11, Jason Merrill<ja...@redhat.com> wrote: >>> On 04/21/2011 07:17 PM, Lawrence Crowl wrote: > >>> That makes sense. Inlines in the class aren't significantly different >>> from inlines outside the class, but inlines are significantly different >>> from non-inlines for our purposes. >> >> Do you have a quick hint for how to make that distinction? > > Check DECL_DECLARED_INLINE_P after we've parsed the declarator. > >>>>>> -DEFTIMEVAR (TV_TEMPLATE_INSTANTIATION, "template instantiation") >>>>>> +DEFTIMEVAR (TV_INSTANTIATE_TEMPLATE , "instantiate template") >>>>> >>>>> Why these changes? >>>> >>>> Just to shorten the names. >>> >>> I'd prefer to keep it in the noun form. >> >> Okay. This on in particular was making the output wide. > > I wouldn't mind shortening it to TV_TEMPLATE_INST, I just object to the > change from noun (instantiation) to verb (instantiate). > >>> The code is cleaner the way you have it, but not as correct, as there's >>> some initialization being charged to parsing. >> >> Would you prefer moving that initialization out or placing the >> start/stop into different routines? > > I think moving the initialization out would be better. > > Jason > -- Lawrence Crowl
