On 12/13/18 12:49 AM, Jakub Jelinek wrote: > Hi! > > On Mon, Dec 10, 2018 at 09:56:46PM -0700, Jeff Law wrote: >> Note that split-path-5 has the same basic structure. A half-diamond >> with a single statement in the middle block that should be trivially >> if-convertable if profitable. So I adjusted that testcase. > > The split-path-5.c testcase now fails on powerpc64*, arm*, aarch64* etc. > targets. > > When looking for the difference, I found out it is a -fsigned-char vs. > -funsigned-char issue, on -funsigned-char targets we are simply compiling > something quite different. > > The following patch fixes it, regtested on x86_64-linux (-m64/-m32) and > tested with cross to aarch64-linux and powerpc64-linux. Ok for trunk? > > 2018-12-13 Jakub Jelinek <ja...@redhat.com> > > PR testsuite/88454 > * gcc.dg/tree-ssa/split-path-5.c (__ctype_ptr__): Change type from > const char * to const signed char *. > (bmhi_init): Change pattern parameter's type the same. Use > __builtin_strlen instead of undeclared strlen. Yea. Interesting that we hadn't had problems with it before. THanks for taking care of it while I was out.
jeff