-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi Colin,
What did you do to make this two patches compilable? I am not able to compile them. I always get compiler errors (and some warnings): preferences.c: In function 'config_window_apply': preferences.c:288:3: warning: implicit declaration of function 'set_image_overlay_font_string' [-Wimplicit-function-declaration] set_image_overlay_font_string(&options->image_overlay.font, ^ preferences.c: In function 'image_overlay_set_font_cb': preferences.c:1026:11: warning: implicit declaration of function 'gtk_font_chooser_dialog_new' [-Wimplicit-function-declaration] dialog = gtk_font_chooser_dialog_new("Image Overlay Font", gtk_widget_get_toplevel(widget)); ^ preferences.c:1026:9: warning: assignment makes pointer from integer without a cast [-Wint-conversion] dialog = gtk_font_chooser_dialog_new("Image Overlay Font", gtk_widget_get_toplevel(widget)); ^ preferences.c:1027:2: warning: implicit declaration of function 'gtk_font_chooser_set_font' [-Wimplicit-function-declaration] gtk_font_chooser_set_font(dialog, options->image_overlay.font); ^ preferences.c:1031:15: warning: implicit declaration of function 'gtk_font_chooser_get_font_desc' [-Wimplicit-function-declaration] font_desc = gtk_font_chooser_get_font_desc(GTK_FONT_CHOOSER(dialog)); ^ preferences.c:1031:46: warning: implicit declaration of function 'GTK_FONT_CHOOSER' [-Wimplicit-function-declaration] font_desc = gtk_font_chooser_get_font_desc(GTK_FONT_CHOOSER(dialog)); ^ preferences.c:1031:13: warning: assignment makes pointer from integer without a cast [-Wint-conversion] font_desc = gtk_font_chooser_get_font_desc(GTK_FONT_CHOOSER(dialog)); ^ preferences.c:1038:21: warning: passing argument 1 of 'gtk_widget_destroy' from incompatible pointer type [-Wincompatible-pointer-types] gtk_widget_destroy(dialog); ^ In file included from /usr/include/gtk-2.0/gtk/gtkcontainer.h:35:0, from /usr/include/gtk-2.0/gtk/gtkbin.h:35, from /usr/include/gtk-2.0/gtk/gtkwindow.h:36, from /usr/include/gtk-2.0/gtk/gtkdialog.h:35, from /usr/include/gtk-2.0/gtk/gtkaboutdialog.h:32, from /usr/include/gtk-2.0/gtk/gtk.h:33, from main.h:55, from preferences.c:14: /usr/include/gtk-2.0/gtk/gtkwidget.h:837:9: note: expected 'GtkWidget * {aka struct _GtkWidget *}' but argument is of type 'GenericDialog * {aka struct _GenericDialog *}' void gtk_widget_destroy (GtkWidget *widget); ^ preferences.c: In function 'config_tab_windows': preferences.c:1479:51: warning: passing argument 4 of 'gtk_box_pack_start' makes integer from pointer without a cast [-Wint-conversion] gtk_box_pack_start(GTK_BOX(hbox), button, FALSE, NULL, 0); ^ In file included from /usr/include/gtk-2.0/gtk/gtkbbox.h:34:0, from /usr/include/gtk-2.0/gtk/gtk.h:46, from main.h:55, from preferences.c:14: /usr/include/gtk-2.0/gtk/gtkbox.h:109:13: note: expected 'gboolean {aka int}' but argument is of type 'void *' void gtk_box_pack_start (GtkBox *box, ... preferences.o: In function `image_overlay_set_font_cb': /home/klaus/devel/upstream/geeqie/src/preferences.c:1026: undefined reference to `gtk_font_chooser_dialog_new' /home/klaus/devel/upstream/geeqie/src/preferences.c:1027: undefined reference to `gtk_font_chooser_set_font' /home/klaus/devel/upstream/geeqie/src/preferences.c:1031: undefined reference to `GTK_FONT_CHOOSER' /home/klaus/devel/upstream/geeqie/src/preferences.c:1031: undefined reference to `gtk_font_chooser_get_font_desc' Regards Klaus - -- Klaus Ethgen http://www.ethgen.ch/ pub 4096R/4E20AF1C 2011-05-16 Klaus Ethgen <kl...@ethgen.ch> Fingerprint: 85D4 CA42 952C 949B 1753 62B3 79D0 B06F 4E20 AF1C -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Charset: ISO-8859-1 iQGcBAEBCgAGBQJXPbS3AAoJEKZ8CrGAGfas0rkL/3481YvNdo25aMd6UKLZ7XCN ZsQ5ObnoIUNIzUYh2S/DwBI7fNrjY16Fn53s4Z/iMf8yHufJhBtO0CBwOWUXFPP2 +2N0KFBH+TSPMJfHymc1TqqY+Xn9EwqWG1BKPBwTZeO7lsfjZrzkbz6+0T9CaXGf SBOQsqHAitGsuZZc27Trqd8jC2osKAakeBDdTZbQlu/Dzg3mpJGfBJgCdvexAbGl hswPUUTg+oSTvGTTsGywIVzQebiwnXNalMrIZ6ydmU6011iNf4ptaX+5YV36nfuy VbJyM+VLv3NFnQ5vAKDI13UUyNDagZPxyJXHALMzqyHtRr6vsr2rDjwfniUZUNnw 2QkyQ+dB0/rN5i47jb/2HynwrbdnlLUZOQcZmDjkI9gh3slCx4KDzFFsrDkITlCV gtSWKXggf5yg66fWnKZdONer5eJwEdWjEdS3Ekm01Bx/1ogFkc8YGj+6m2GiHPuq L8snPnKA+pLmApKdD85vLmEuyCXRaUG7Hx3w8h1iyA== =dhN9 -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ Mobile security can be enabling, not merely restricting. Employees who bring their own devices (BYOD) to work are irked by the imposition of MDM restrictions. Mobile Device Manager Plus allows you to control only the apps on BYO-devices by containerizing them, leaving personal data untouched! https://ad.doubleclick.net/ddm/clk/304595813;131938128;j _______________________________________________ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel