----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2925/#review6626 -----------------------------------------------------------
Ship it! Ship It! - Nilay Vaish On June 26, 2015, 9:26 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2925/ > ----------------------------------------------------------- > > (Updated June 26, 2015, 9:26 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10882:aa4838948984 > --------------------------- > mem: Convert Request static const flags to enums > > This patch fixes an issue which is very wide spread in the codebase, > causing sporadic linking failures. The issue is that we declare static > const class variables in the header, without any definition (as part > of a source file). In most cases the compiler propagates the value and > we have no issues. However, especially for less optimising builds such > as debug, we get sporadic linking failures due to undefined > references. > > This patch fixes the Request class, by turning the static const flags > and master IDs into C++11 typed enums. > > > Diffs > ----- > > src/mem/request.hh 73d4798871a5 > > Diff: http://reviews.gem5.org/r/2925/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
