Yu-hsin Wang has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/72058?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: scons: Update default environment comments
......................................................................
scons: Update default environment comments
Change-Id: Ib6dcf1a6390010682365f393241c1e022aeeb813
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/72058
Reviewed-by: Jason Lowe-Power <power...@gmail.com>
Maintainer: Jason Lowe-Power <power...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M site_scons/gem5_scons/defaults.py
1 file changed, 10 insertions(+), 10 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/site_scons/gem5_scons/defaults.py
b/site_scons/gem5_scons/defaults.py
index 944f7e5..aeca94f 100644
--- a/site_scons/gem5_scons/defaults.py
+++ b/site_scons/gem5_scons/defaults.py
@@ -44,7 +44,7 @@
def EnvDefaults(env):
- # export TERM so that clang reports errors in color
+ # initialize the toolchain related env with host environment
use_vars = set(
[
"AS",
@@ -60,15 +60,15 @@
"PROTOC",
"PYTHONPATH",
"RANLIB",
- "TERM",
- "PYTHON_CONFIG",
- "CCFLAGS_EXTRA",
- "GEM5PY_CCFLAGS_EXTRA",
- "GEM5PY_LINKFLAGS_EXTRA",
- "LINKFLAGS_EXTRA",
- "LANG",
- "LC_CTYPE",
- "DISPLAY",
+ "TERM", # for clang reports errors in color
+ "PYTHON_CONFIG", # gem5 specific build env
+ "CCFLAGS_EXTRA", # gem5 specific build env
+ "GEM5PY_CCFLAGS_EXTRA", # gem5 specific build env
+ "GEM5PY_LINKFLAGS_EXTRA", # gem5 specific build env
+ "LINKFLAGS_EXTRA", # gem5 specific build env
+ "LANG", # for work with non-ascii directory path
+ "LC_CTYPE", # for work with non-ascii directory path
+ "DISPLAY", # for gui program, ex kconfig guiconfig
]
)
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/72058?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib6dcf1a6390010682365f393241c1e022aeeb813
Gerrit-Change-Number: 72058
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-hsin Wang <yuhsi...@google.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: Yu-hsin Wang <yuhsi...@google.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-CC: kokoro <noreply+kok...@google.com>
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
