----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/717/#review1261 -----------------------------------------------------------
Ship it! Looks fine to me. - Nilay On 2011-05-24 10:15:40, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/717/ > ----------------------------------------------------------- > > (Updated 2011-05-24 10:15:40) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > slicc: add a protocol statement and an include statement > All protocols must specify their name > The include statement allows any file to include another file. > > > Diffs > ----- > > src/mem/protocol/MESI_CMP_directory.slicc 3f37cc5d25bc > src/mem/protocol/MI_example.slicc 3f37cc5d25bc > src/mem/protocol/MOESI_CMP_directory.slicc 3f37cc5d25bc > src/mem/protocol/MOESI_CMP_token.slicc 3f37cc5d25bc > src/mem/protocol/MOESI_hammer.slicc 3f37cc5d25bc > src/mem/protocol/Network_test.slicc 3f37cc5d25bc > src/mem/protocol/RubySlicc_interfaces.slicc 3f37cc5d25bc > src/mem/protocol/SConscript 3f37cc5d25bc > src/mem/slicc/main.py 3f37cc5d25bc > src/mem/slicc/parser.py 3f37cc5d25bc > > Diff: http://reviews.m5sim.org/r/717/diff > > > Testing > ------- > > Quick Regressions, Compile everything > > > Thanks, > > Nathan > > _______________________________________________ gem5-dev mailing list gem5-dev@m5sim.org http://m5sim.org/mailman/listinfo/gem5-dev
