On Thu, Jan 6, 2011 at 1:12 PM, Grant Ingersoll <gsing...@apache.org> wrote:
> Hi,
>
> The Apache ManifoldCF community has voted to release our first set of 
> artifacts and now would like an Incubator vote.  Since this is our first 
> release, extra attention to detail is appreciated.
>
> You can find the artifacts at http://people.apache.org/~kwright/
>
>
> Thanks,
> Grant
>

I've reviewed this and think it mostly fine.

The NOTICE file does include some unnecessary things, i don't think
thats technically a blocking issue but as this is the first RC of the
first release it should probably be cleaned up and another RC done.
The NOTICE file should only include required notices that other text
if its really needed could go in a README file, see
http://www.apache.org/legal/src-headers.html#notice

I think this current source+binary distribution is fine. The "rule" is
that you can only release binary artifacts which also have the source
released, but there are no rules saying the source distribution must
not include any binary artifacts, so if this is what the project
thinks works best then its fine.

It is missing the Incubating disclaimer text which should be included
in the README or a DISCLAIMER file, see
http://incubator.apache.org/guides/branding.html#disclaimers

I tried building it with "ant build" and that failed, don't know if
that my environment or something else:
BUILD FAILED
C:\ASF\manifoldcf\apache-manifoldcf-0.1-incubator\build.xml:353: The
following error occurred while executing this line:
C:\ASF\manifoldcf\apache-manifoldcf-0.1-incubator\connectors\jdbc\build.xml:52:
C:\ASF\manifoldcf\apache-manifoldcf-0.1-incubator\co
nnectors\jdbc\jdbc-drivers does not exist.

Other than that it looks ok to me. Its big and inlcudes some duplicate
stuff but if thats what the project thinks is the best approach then
its fine, there are plenty of other big projects being distributed.

   ..ant

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to