Hi Leerho,

Yes, indeed that is what we need to do.

@Wewei Yang, Congrats!

Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University



leerho <lee...@gmail.com> 于2021年2月3日周三 上午4:17写道:

> Xiangdong, I noticed in your GHA yaml script you included the
> Coveralls-repo-token in plaintext, which is not recommended.  You can have
> INFRA load the token into the GitHub repo, which you can then acquire
> securely using GHA secrets.
>
> That is what we do anyway :)
>
> Cheers,
> Lee.
>
> On Tue, Feb 2, 2021 at 12:18 AM Yuanbo Liu <liuyuanb...@gmail.com> wrote:
>
> > It would be great if we could run a travis job on a private machine. I
> > believe some companies would be glad to donate machines
> > for unit testing of open source projects.
> >
> > On Tue, Feb 2, 2021 at 3:10 PM leerho <lee...@gmail.com> wrote:
> >
> > > Xiangdong,
> > > Thank you, I pretty much came up with the same solution.  Nonetheless,
> It
> > > will be interesting to see how your approach differs from mine, I'm
> sure
> > I
> > > will learn something!
> > >
> > > Cheers,
> > >
> > > Lee.
> > >
> > > On Mon, Feb 1, 2021 at 8:04 PM Xiangdong Huang <saint...@gmail.com>
> > wrote:
> > >
> > > > Hi leerho,
> > > >
> > > > > because the current GHA
> > > > adapter for Coveralls only supports LCOV format which Jacoco doesn’t
> > > > generate.
> > > >
> > > > Actually, we can find some way to bypass the LCOV requirements,
> > > > that is... do not use official github action provided by coverall.
> > > >
> > > > In our project (Apache IoTDB), we use maven to compile the project
> and
> > > > use maven plugin to upload code coverage results to Coveralls.
> > > >
> > > > see [1] (search "coveralls"), [2], and [3] (search "Coveralls)".
> > > >
> > > > It works well.
> > > >
> > > > [1] https://github.com/apache/iotdb/blob/master/pom.xml
> > > > [2] https://github.com/apache/iotdb/tree/master/code-coverage
> > > > [3]
> > > >
> > > >
> > >
> >
> https://github.com/apache/iotdb/blob/master/.github/workflows/main-linux.yml
> > > >
> > > > Best,
> > > > -----------------------------------
> > > > Xiangdong Huang
> > > > School of Software, Tsinghua University
> > > >
> > > >  黄向东
> > > > 清华大学 软件学院
> > > >
> > > >
> > > > leerho <lee...@gmail.com> 于2021年2月1日周一 上午10:25写道:
> > > >
> > > > > Sorry, I must be missing something.  I don't see LCOV format in the
> > > list
> > > > :)
> > > > > Doesn't this mean a complete rework of our toolchain ?
> > > > >
> > > > > On Sun, Jan 31, 2021 at 1:19 PM Matt Sicker <boa...@gmail.com>
> > wrote:
> > > > >
> > > > > > Using https://github.com/jenkinsci/warnings-ng-plugin (already
> > > > > > installed) combined with the github integration (also installed),
> > you
> > > > > > can get that in our CloudBees CI instance. They support a lot of
> > > > > > formats:
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/jenkinsci/warnings-ng-plugin/blob/master/SUPPORTED-FORMATS.md
> > > > > >
> > > > > > On Sun, 31 Jan 2021 at 00:53, leerho <lee...@gmail.com> wrote:
> > > > > > >
> > > > > > > I am trying to move from Travis to GitHub actions for exactly
> > this
> > > > > > reason,
> > > > > > > but in that process discovered that our coverage reporting
> chain
> > of
> > > > > > > Maven/Java/Jacoco/Coveralls does not port to GHA because the
> > > current
> > > > > GHA
> > > > > > > adapter for Coveralls only supports LCOV format which Jacoco
> > > doesn’t
> > > > > > > generate.  Converting to CodeCov is a nonstarter because
> CodeCov
> > is
> > > > $$!
> > > > > > >
> > > > > > > If anybody has any ideas, please let me know!
> > > > > > >
> > > > > > > Lee.
> > > > > > >
> > > > > > > On Thu, Jan 28, 2021 at 10:02 PM Weiwei Yang <w...@apache.org>
> > > > wrote:
> > > > > > >
> > > > > > > > Oh, that's good. Then we have no problem at all.
> > > > > > > > Thank you Daniel for pointing this out : )
> > > > > > > >
> > > > > > > > On Thu, Jan 28, 2021 at 9:48 PM Daniel Widdis <
> > wid...@gmail.com>
> > > > > > wrote:
> > > > > > > >
> > > > > > > > > The quota is for private repos.  Public/open-source repos
> are
> > > > > > essentially
> > > > > > > > > unlimited.
> > > > > > > > >
> > > > > > > > > On 1/28/21, 9:44 PM, "Weiwei Yang" <w...@apache.org>
> wrote:
> > > > > > > > >
> > > > > > > > >     Thank you all for the suggestions.
> > > > > > > > >     Looks like github action is an option, we'll give a
> try.
> > > > > > > > >     Noticed they offer 2000 action minutes/month[1] for
> > free, I
> > > > > think
> > > > > > > > that
> > > > > > > > >     should be enough for most cases.
> > > > > > > > >
> > > > > > > > >     [1]
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://docs.github.com/en/github/setting-up-and-managing-billing-and-payments-on-github/about-billing-for-github-actions
> > > > > > > > >
> > > > > > > > >     On Thu, Jan 28, 2021 at 6:36 PM Matt Sicker <
> > > > boa...@gmail.com>
> > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > >     > There's also some hosted CI services here like
> Jenkins,
> > > > > > BuildBot,
> > > > > > > > >     > etc., which may have less queueing issues depending
> on
> > > > which
> > > > > > > > service
> > > > > > > > >     > attracts the most build minute usage.
> > > > > > > > >     >
> > > > > > > > >     > On Thu, 28 Jan 2021 at 20:23, Jon Malkin <
> > > > > jon.mal...@gmail.com
> > > > > > >
> > > > > > > > > wrote:
> > > > > > > > >     > >
> > > > > > > > >     > > There was an issue a few months ago where the
> GitHub
> > > > > Actions
> > > > > > > > queue
> > > > > > > > > was
> > > > > > > > >     > very
> > > > > > > > >     > > laggy for Apache jobs, so just make sure you're
> > trying
> > > to
> > > > > be
> > > > > > > > > efficient
> > > > > > > > >     > > about it. It's also a shared resource.
> > > > > > > > >     > >
> > > > > > > > >     > > That said, (part of) our recently graduated project
> > > uses
> > > > > > GitHub
> > > > > > > > > Actions
> > > > > > > > >     > and
> > > > > > > > >     > > we've been happy overall. Another part is currently
> > > > moving
> > > > > > to it
> > > > > > > > > from
> > > > > > > > >     > > Travis for the exact same reason.
> > > > > > > > >     > >
> > > > > > > > >     > >   jon
> > > > > > > > >     > >
> > > > > > > > >     > > On Thu, Jan 28, 2021, 6:15 PM Juan Pan <
> > > > panj...@apache.org
> > > > > >
> > > > > > > > wrote:
> > > > > > > > >     > >
> > > > > > > > >     > > > Hi Weiwei,
> > > > > > > > >     > > >
> > > > > > > > >     > > >
> > > > > > > > >     > > > +1 for Jeff’s suggestion.
> > > > > > > > >     > > > We also transfer to GitHub Action, and It
> generally
> > > > works
> > > > > > well
> > > > > > > > > so far.
> > > > > > > > >     > > >
> > > > > > > > >     > > >
> > > > > > > > >     > > >
> > > > > > > > >     > > >
> > > > > > > > >     > > >
> > > > > > > >
> > ----------------------------------------------------------------
> > > > > > > > >     > > >    Juan Pan (Trista)
> > > > > > > > >     > > >
> > > > > > > > >     > > > Senior DBA & PMC of Apache ShardingSphere
> > > > > > > > >     > > > E-mail: panj...@apache.org
> > > > > > > > >     > > >
> > > > > > > > >     > > >
> > > > > > > > >     > > >
> > > > > > > > >     > > >
> > > > > > > > >     > > > On 01/29/2021 08:00,Jeff Zhang<zjf...@gmail.com>
> > > > wrote:
> > > > > > > > >     > > > Hi Weiwei,
> > > > > > > > >     > > >
> > > > > > > > >     > > > May you can consider to use github action for CI
> > > > > > > > >     > > >
> > > > > > > > >     > > >
> > > > > > > > >     > > >
> > > > > > > > >     > > > Weiwei Yang <w...@apache.org> 于2021年1月29日周五
> > > 上午7:58写道:
> > > > > > > > >     > > >
> > > > > > > > >     > > > Hi,
> > > > > > > > >     > > >
> > > > > > > > >     > > > The Apache YuniKorn (Incubating) team leverages
> > > Travis
> > > > to
> > > > > > run
> > > > > > > > >     > pre-commit
> > > > > > > > >     > > > checks, but recently the Travis Job stays in the
> > > queue
> > > > > for
> > > > > > long
> > > > > > > > > hours
> > > > > > > > >     > (6+
> > > > > > > > >     > > > hours, sometimes more than 10 hours) . This is
> > highly
> > > > > > impacting
> > > > > > > > > the
> > > > > > > > >     > > > productivity. I have reached the Travis support
> and
> > > the
> > > > > > > > response
> > > > > > > > > I got
> > > > > > > > >     > was
> > > > > > > > >     > > > the jobs got rate limited under Apache repo. Is
> > there
> > > > any
> > > > > > > > > suggestion
> > > > > > > > >     > how to
> > > > > > > > >     > > > fix this issue?
> > > > > > > > >     > > >
> > > > > > > > >     > > > Thanks
> > > > > > > > >     > > > Weiwei
> > > > > > > > >     > > >
> > > > > > > > >     > > >
> > > > > > > > >     > > >
> > > > > > > > >     > > > --
> > > > > > > > >     > > > Best Regards
> > > > > > > > >     > > >
> > > > > > > > >     > > > Jeff Zhang
> > > > > > > > >     > > >
> > > > > > > > >     >
> > > > > > > > >     >
> > > > > > > >
> > > > ---------------------------------------------------------------------
> > > > > > > > >     > To unsubscribe, e-mail:
> > > > > > general-unsubscr...@incubator.apache.org
> > > > > > > > >     > For additional commands, e-mail:
> > > > > > general-h...@incubator.apache.org
> > > > > > > > >     >
> > > > > > > > >     >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > > > > > To unsubscribe, e-mail:
> > > general-unsubscr...@incubator.apache.org
> > > > > > > > > For additional commands, e-mail:
> > > > general-h...@incubator.apache.org
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > --
> > > > > > > From my cell phone.
> > > > > >
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > > > > For additional commands, e-mail:
> general-h...@incubator.apache.org
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Reply via email to