+1 binding Please remember to update the installation page, replace the current content with the first Apache release, and remove all the prior releases refs, once this release is concluded.
Otherwise, if you'd like to keep the refs to prior releases, make it clear that they are not Apache releases. I checked: [x] Download Fury is valid. [x] Checksums and PGP signatures are valid. apache-fury-incubating-0.5.0-src.tar.gz gpg: Signature made 三 4/17 23:49:45 2024 CST gpg: using RSA key 1E2CDAE4C08AD7D694D1CB139D7BE8E45E580BA4 gpg: Good signature from "chaokunyang (CODE SIGNING KEY) < chaokuny...@apache.org>" [unknown] gpg: WARNING: This key is not certified with a trusted signature! gpg: There is no indication that the signature belongs to the owner. Primary key fingerprint: 1E2C DAE4 C08A D7D6 94D1 CB13 9D7B E8E4 5E58 0BA4 [x] Source code distributions have correct names matching the current release. [x] LICENSE, NOTICE, and DISCLAIMER files are correct. [x] All files have license headers if necessary. [x] No compiled archives bundled in source archive. [x] Build from source: # work on macOS M2 & JDK 22 cd java mvn clean install -DskipTests=true # work on macOS M2 & nightly toolchain cd rust cargo test Best, tison. tison <wander4...@gmail.com> 于2024年4月23日周二 19:44写道： > > I would be very disappointed if the podling published the code > > *knowing* that the download page is missing or incorrect. > > IIUC Fury will update the content and delete all the references to prior > releases. > > Or instead, Fury can keep these references and state clearly it's prior > releases. > > My comment above is with an assumption that prior releases ref will be > removed. But if the PPMC wants to keep it, they should update the > description. > > Best, > tison. > > > sebb <seb...@gmail.com> 于2024年4月23日周二 19:35写道： > >> On Tue, 23 Apr 2024 at 09:42, tison <wander4...@gmail.com> wrote: >> > >> > > There is no indication that 0.4.1 is not an ASF release. >> > >> > You may found that the group id is not org.apache.fury also. >> >> Whilst this is true, it is still not obvious that this is not an ASF >> release; it is easy to overlook this minor detail. >> >> Indeed, there is no such indication for the GoLang, Javascript or Rust >> binaries. >> >> > This is an intermediate state that we would update the content as: >> > >> > <dependency> >> > <groupId>org.apache.fury</groupId> >> > <artifactId>fury-core</artifactId> >> > <version>0.5.0</version> >> > </dependency> >> > >> > And then the content is correct. >> >> Strictly speaking the content of the Maven reference to 0.4.1 is not >> 'incorrect'. >> The problem is that the page does not make it clear that the release >> is not an ASF release. >> >> It's OK to refer to prior releases, but the reader must be clearly >> informed of their provenance. >> >> > If we make any workaround or patch to make >> > it "look good", it would be updated as soon as 0.5.0 is released. So I >> > won't treat that as a release blocker. >> >> I would be very disappointed if the podling published the code >> *knowing* that the download page is missing or incorrect. >> >> > Best, >> > tison. >> > >> > >> > sebb <seb...@gmail.com> 于2024年4月23日周二 15:59写道： >> > >> > > On Mon, 22 Apr 2024 at 10:11, PJ Fanning <fannin...@apache.org> >> wrote: >> > > > >> > > > Hi Sebb, >> > > > This email thread is a vote for an RC. If this vote passes, v0.5.0 >> > > > will be the first release of Fury since it became a podling. >> > > > We will add a download page but at the moment, there is nothing to >> > > > link to there (except perhaps a KEYS file). >> > > > >> > > > The Install page does need to be updated to not mention snapshots. >> > > >> > > If 0.5.0 is to be the first ASF release, then the Install page is very >> > > misleading. >> > > >> > > There is no indication that 0.4.1 is not an ASF release. >> > > >> > > > Thanks, >> > > > PJ >> > > > >> > > > On Mon, 22 Apr 2024 at 10:35, sebb <seb...@gmail.com> wrote: >> > > > > >> > > > > On Sat, 20 Apr 2024 at 16:26, Shawn Yang <shawn.ck.y...@gmail.com >> > >> > > wrote: >> > > > > > >> > > > > > Hello everyone, >> > > > > > >> > > > > > This is a call for the vote to release Apache Fury(Incubating) >> > > v0.5.0-rc3. >> > > > > > >> > > > > > The Apache Fury community has voted and approved the release of >> > > Apache >> > > > > > Fury(incubating) v0.5.0-rc3. We now kindly request the IPMC >> members >> > > > > > review and vote for this release. >> > > > > > >> > > > > > Apache Fury(incubating) - A blazingly fast multi-language >> > > serialization >> > > > > > framework powered by JIT and zero-copy. >> > > > > > >> > > > > > Fury community vote thread: >> > > > > > >> https://lists.apache.org/thread/g49qt1v99d0ncfvonng39lcs1s56m7v5 >> > > > > > >> > > > > > Vote result thread: >> > > > > > >> https://lists.apache.org/thread/9rtl03g650pojyfb5d67785tffyo4hbs >> > > > > > >> > > > > > The release candidate: >> > > > > > >> https://dist.apache.org/repos/dist/dev/incubator/fury/0.5.0-rc3/ >> > > > > > >> > > > > > This release has been signed with a PGP available here: >> > > > > > https://downloads.apache.org/incubator/fury/KEYS >> > > > > > >> > > > > >> > > > > I could not find a proper download page for the release. >> > > > > This must have links to the source bundle which must use >> closer.lua, >> > > > > as well as links to KEYS, sigs and hashes, with instructions on >> how to >> > > > > validate downloads. >> > > > > >> > > > > There is an install page on the website at >> > > > > https://fury.apache.org/docs/start/install, but that does not >> link to >> > > > > any source bundle. >> > > > > >> > > > > Furthermore, the install page links to nightly snapshots; this is >> not >> > > > > allowed except on a page intended for Fury developers, who should >> be >> > > > > made aware that nightly code has not been vetted. >> > > > > >> > > > > > Git tag for the release: >> > > > > > >> https://github.com/apache/incubator-fury/releases/tag/v0.5.0-rc3 >> > > > > > >> > > > > > Git commit for the release: >> > > > > > >> > > >> https://github.com/apache/incubator-fury/commit/fae06330edd049bb960536e978a45b97bca66faf >> > > > > > >> > > > > > Maven staging repo: >> > > > > > >> > > https://repository.apache.org/content/repositories/orgapachefury-1003 >> > > > > > >> > > > > > How to Build and Test, please refer to: >> > > > > > >> > > >> https://github.com/apache/incubator-fury/blob/main/docs/guide/DEVELOPMENT.md >> > > > > > >> > > > > > The vote will be open for at least 72 hours or until the >> necessary >> > > number >> > > > > > of votes is reached. >> > > > > > >> > > > > > Please vote accordingly: >> > > > > > >> > > > > > [ ] +1 approve >> > > > > > [ ] +0 no opinion >> > > > > > [ ] -1 disapprove with the reason >> > > > > > >> > > > > > To learn more about apache fury, please see >> https://fury.apache.org/ >> > > > > > >> > > > > > Checklist for reference: >> > > > > > >> > > > > > [ ] Download links are valid. >> > > > > > [ ] Checksums and signatures. >> > > > > > [ ] LICENSE/NOTICE files exist >> > > > > > [ ] No unexpected binary files >> > > > > > [ ] All source files have ASF headers >> > > > > > [ ] Can compile from source >> > > > > > >> > > > > > >> > > > > > Thanks, >> > > > > > >> > > > > > Chaokun Yang >> > > > > >> > > > > >> --------------------------------------------------------------------- >> > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> > > > > For additional commands, e-mail: >> general-h...@incubator.apache.org >> > > > > >> > > > >> > > > >> --------------------------------------------------------------------- >> > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> > > > For additional commands, e-mail: general-h...@incubator.apache.org >> > > > >> > > >> > > --------------------------------------------------------------------- >> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> > > For additional commands, e-mail: general-h...@incubator.apache.org >> > > >> > > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >>
