On Tue, Aug 22, 2017 at 6:34 AM, Nils Freydank <nils.freyd...@posteo.de> wrote: > Am Dienstag, 22. August 2017, 09:01:07 CEST schrieb Raffaele Belardi: >> […] >> > [1] https://bugs.gentoo.org/show_bug.cgi?id=604430 >> > [2] https://bugs.gentoo.org/show_bug.cgi?id=575232 >> >> Just as follow up, inspired by [2] I fixed the mythtv build issue by >> adding #include <sys/sysmacros.h> to videosource.cpp and continuing the >> build with ebuild instead of emerge. > Great! In general, to improve Gentoo a bit further, you could create a patch > at this point, test applying it via /etc/portage/patches/ and add it to the > bugtracker (or paste it here or in IRC asking someone to paste it in your > name) ;-) >
Per the comment I made in the bug, if you're going to patch, I'd use upstream's patch - the commit for 0.28 is: https://github.com/MythTV/mythtv/commit/b012ff0f6b284969183863d42a6a14eb77ed0a1d In general it is ALWAYS better to use the upstream patch. Plus if you need to get a Gentoo dev to commit it for you you'll get less push-back that way if you reference it in a bug. > > BTW, mythtv has no maintainer, might you be interested in a proxied > maintainership? > I'd encourage somebody to step up and do this - I no longer use it and MythTV is one of those packages that you really need to use if you want to maintain it (hardware/etc, plus a fair bit of work). If somebody steps up and wants tips please do feel free to ping me, and I suspect cardoe would also be willing. In general though upstream maintains git branches for each of their releases under fixes/ that track stuff like this. This commit was in fixes/0.28. These are stable branches and very unlikely to break anything - and this was the basis of all the updates within a release on Gentoo previously. The minor releases like 0.28.1 are just tagged versions off of these branches - 0.28 plus all the fixes up to that point in time is basically the same as 0.28.1. The ebuild is designed to make it easy to pull these in - I see that cardoe pointed it at github so in theory you can just change the hash to the new head and it will probably pull in all the fixes. They're up to 0.29 now. That isn't in the 0.28 fixes branch, and might need a bit more testing. -- Rich
