On Thu, Mar 9, 2017 at 6:00 PM, Christian Couder <christian.cou...@gmail.com> wrote: > On Thu, Mar 9, 2017 at 10:53 AM, Prathamesh Chavan <pc44...@gmail.com> wrote: >> Whenever a git command is present in the upstream of a pipe, its failure >> gets masked by piping and hence it should be avoided for testing the >> upstream git command. By writing out the output of the git command to >> a file, we can test the exit codes of both the commands as a failure exit >> code in any command is able to stop the && chain. >> >> Signed-off-by: Prathamesh <pc44...@gmail.com> >> --- > > Please add in Cc those who previously commented on the patch.
Actually I initially used submitGit to send patches, where there was no option of adding cc to the patch. But after your comment I have switched to git send-email and git format-patch for sending patches. > >> t/t2027-worktree-list.sh | 14 +++++++------- >> 1 file changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/t/t2027-worktree-list.sh b/t/t2027-worktree-list.sh >> index 848da5f..daa7a04 100755 >> --- a/t/t2027-worktree-list.sh >> +++ b/t/t2027-worktree-list.sh >> @@ -31,7 +31,7 @@ test_expect_success '"list" all worktrees from main' ' >> test_when_finished "rm -rf here && git worktree prune" && >> git worktree add --detach here master && >> echo "$(git -C here rev-parse --show-toplevel) $(git rev-parse >> --short HEAD) (detached HEAD)" >>expect && >> - git worktree list | sed "s/ */ /g" >actual && >> + git worktree list >out && sed "s/ */ /g" <out >actual && > > I still think that it would be better if the 'sed' commend was on its > own line like this: > > + git worktree list >out && > + sed "s/ */ /g" <out >actual && > >> test_cmp expect actual >> '
