Hi Junio, On Mon, 13 Mar 2017, Junio C Hamano wrote:
> David Aguilar <dav...@gmail.com> writes: > > > Detect the null object ID for symlinks in dir-diff so that difftool > > can prepare temporary files that matches how git handles symlinks. > > > > Previously, a null object ID would crash difftool. We now detect null > > object IDs and write the symlink's content into the temporary symlink > > stand-in file. > > > > Original-patch-by: Johannes Schindelin <johannes.schinde...@gmx.de> > > Signed-off-by: David Aguilar <dav...@gmail.com> > > --- > > I would have appreciated (and I suspect other reviewers would, too) > a bit of back-story wrt how "Original-patch-by" resulted in this > patch after the three-dashes line. It is perfectly fine if you two > coordinated privately; I mostly wanted to hear something like "Dscho > has been working on this and I asked him if it is OK to take over > his WIP to produce a quick-fix we can ship on the maint branch, here > is the result of that collaboration." IOW, the person who is named > as the original author is fine to be named like so (I care only > because I do not think we saw the "original" here on the list). The story is more like: Johannes started working on this but got pulled away by other tasks and sent out a link to the initial patch, along with a note that he hopes to be able to get back to working on that patch before long (but of course he did not get the chance): http://public-inbox.org/git/alpine.DEB.2.20.1703072332370.3767@virtualbox/ There was no private exchange. I am happy that David picked up the project. Ciao, Johannes
