Junio C Hamano <gits...@pobox.com> writes:
> Stefan Beller <sbel...@google.com> writes:
>
>> As 'var' contains the whole value we get error messages that repeat
>> the section and key currently:
>>
>> warning: Invalid parameter 'true' for config option
>> 'submodule.submodule.plugins/hooks.ignore.ignore'
>>
>> Fix this by only giving the section name in the warning.
>>
>> Signed-off-by: Stefan Beller <sbel...@google.com>
>> ---
>> submodule-config.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/submodule-config.c b/submodule-config.c
>> index 93453909cf..bb069bc097 100644
>> --- a/submodule-config.c
>> +++ b/submodule-config.c
>> @@ -333,7 +333,7 @@ static int parse_config(const char *var, const char
>> *value, void *data)
>> strcmp(value, "all") &&
>> strcmp(value, "none"))
>> warning("Invalid parameter '%s' for config option "
>> - "'submodule.%s.ignore'", value, var);
>> + "'submodule.%s.ignore'", value,
>> name.buf);
>
> Obviously correct.
But isn't this even more obviously correct?
warning("invalid parameter '%s' for option %s", value, var);
