On Fri, Apr 21, 2017 at 6:57 PM, Christian Couder <christian.cou...@gmail.com> wrote: > On Fri, Apr 21, 2017 at 1:46 PM, Christian Couder > <christian.cou...@gmail.com> wrote: >> On Fri, Apr 21, 2017 at 11:53 AM, Duy Nguyen <pclo...@gmail.com> wrote: >>> On Fri, Apr 21, 2017 at 2:10 PM, Christian Couder >>> <christian.cou...@gmail.com> wrote: >>>> On Thu, Apr 20, 2017 at 11:24 PM, Thomas Gummerer <t.gumme...@gmail.com> >>>> wrote: >>>>> On 04/20, Christian Couder wrote: >>>>>> >>>>>> Could you try with the following patch: >>>>>> >>>>>> http://public-inbox.org/git/20170330210354.20018-1-chrisc...@tuxfamily.org/ >>>>> >>>>> Yeah, I tried with and without that patch with the same result. >>>>> Unless I'm screwing something up when testing I don't think this fixes >>>>> the issue unfortunately. >>>> >>>> Ok, I will take a look soon. >>>> >>>> By the way I think that GIT_TEST_SPLIT_INDEX has become redundant now >>>> that there is core.splitIndex. >>>> So perhaps in the long run it will be best to deprecate >>>> GIT_TEST_SPLIT_INDEX and eventually remove it. >>> >>> I think you can't, at least the way I understand this variable. It's a >>> _test_ variable to force exercise split index code path a whole lot >>> more, by running the entire test suite with split index always >>> enabled, instead of just a couple in t????-split-index.sh. We can't >>> achieve the same with core.splitIndex because that's more about user >>> control and you can't just set core.splitIndex for the entire test >>> suite (can we?). >> >> Yeah, you are right. >> It looks like we have GIT_TEST_OPTS to pass options like --debug, >> --valgrind, --verbose, but we don't have an environment variable to >> set config options. > > Or maybe GIT_CONFIG_PARAMETERS works for this purpose?
It has to be set inside test-lib.sh, not from outside because environment variables from outside are filtered if I remember correctly and only a few specials plus those GIT_TEST_ can survive. Some tests override GIT_CONFIG_PARAMETERS themselves to pass config vars to certain command (I know because I just did a couple days ago ;).which loses core.splitIndex. -- Duy
