Hi Junio,
On Mon, 29 May 2017, Junio C Hamano wrote:
> Johannes Schindelin <johannes.schinde...@gmx.de> writes:
>
> > diff --git a/sequencer.c b/sequencer.c
> > index 130cc868e51..88819a1a2a9 100644
> > --- a/sequencer.c
> > +++ b/sequencer.c
> > @@ -2388,3 +2388,52 @@ void append_signoff(struct strbuf *msgbuf, int
> > ignore_footer, unsigned flag)
> >
> > strbuf_release(&sob);
> > }
> > +
> > +int sequencer_make_script(int keep_empty, FILE *out,
> > + int argc, const char **argv)
> > +{
> > + char *format = NULL;
> > + struct pretty_print_context pp = {0};
> > + struct strbuf buf = STRBUF_INIT;
> > + struct rev_info revs;
> > + struct commit *commit;
> > +
> > + init_revisions(&revs, NULL);
> > + revs.verbose_header = 1;
> > + revs.max_parents = 1;
> > + revs.cherry_pick = 1;
> > + revs.limited = 1;
> > + revs.reverse = 1;
> > + revs.right_only = 1;
> > + revs.sort_order = REV_SORT_IN_GRAPH_ORDER;
> > + revs.topo_order = 1;
>
> cf. <xmqq4lx5i83q....@gitster.mtv.corp.google.com>
>
> This is still futzing below the API implementation detail
> unnecessarily.
You still ask me to pass options in plain text that has to be parsed at
run-time, rather than compile-time-verifiable flags.
I am quite puzzled that you keep asking me to make my code sloppy.
Ciao,
Dscho
