On Mon, Jul 24, 2017 at 12:29:04PM -0700, Junio C Hamano wrote: > > There's already some prior art around trailers in the trailer.* config. > > I wonder if it would make sense to claim a new key there, like: > > > > git config trailer.Reported-by.autocc true > > > > If "Reported-by" is a trailer that your project uses, then there may be > > some benefit to setting up other config related to it, and this would > > mesh nicely. And then potentially other programs besides git-contacts > > would want to respect that flag (perhaps send-email would even want to > > do it itself; I think it already respects cc and s-o-b headers). > > Sounds like a good suggestion. But... > > If I understand your proposal, the trailer stuff would still not > care what value .autocc is set to while doing its own thing, but the > programs that read the text file that the trailer can work on would > pay attention to it, and they individually have to do so? Perhaps > there is a need for another mode "interpret-trailers" is told to run > in, where it is given a text file with trailers in it and is told to > show only the value that has .autocc bit on? Alternatively, yield > <key, value> pairs so that the user of the tool can further process > the value differently depending on the key, or something?
Yeah, I don't think interpret-trailers is currently a useful tool for looking at an extra config key like that. I'd expect it would need to be extended, or a new tool added, or perhaps existing tools would need to learn more about how trailers work (e.g., it would be nice if git-log could do matching or even print them via %(trailer:reported-by) placeholders or something). I think there's a lot of potential work in that area. Of course git-contacts (or send-email) _can_ just look look at all of the trailer.*.autocc config and try to match those manually. But the point of having trailer config, I think, is that we should stop doing ad-hoc parsing and have a tool for manipulating and querying trailers. If interpret-trailers isn't up to the task yet, I'd rather see work go there. But that (manual parsing) is basically how the current cc and s-o-b trailers implemented inside of git-send-email, so I don't think it would be the end of the world as a quick hack that could later be expanded to use the trailer infrastructure. -Peff
