Hi Junio, On Thu, 9 Oct 2014, Junio C Hamano wrote:
> Marat Radchenko <ma...@slonopotamus.org> writes: > > > On Wed, Oct 08, 2014 at 12:26:52PM -0700, Junio C Hamano wrote: > > ... > >> What I am wondering is if it is a better solution to make it easier > >> to allow somebody who is cross compiling to express "Mr. Makefile, > >> we know better than you and want you to do a MINGW build for us > >> without checking with `uname -?` yourself", i.e. > >> > >> $ make uname_O=MINGW uname_S=MINGW > >> > >> which would hopefully allow cross-compilation into other > >> environments, not just MINGW. > > > > So, do you really want this patch to be changed from 5-liner into > > a full-blow system detection rewrite based on `cc -dumpmachine` > > instead of `uname`? > > No, and I do not quite see why you even need to look at -dumbmachine Nice Freudian ;-) > output when your goal is to make this command line > > >> $ make uname_O=MINGW uname_S=MINGW > > work sensibly. Wouldn't it be more like a series of > > ifndef uname_O > uname_O := $(shell uname -o) > endif > > or something like that? Or uname_O ?= $(shell uname -o) To clarify: it would be enough to look at CROSS_COMPILE to determine whether we're cross-compiling for MinGW. The output of -dumpmachine is still needed for the correct CFLAGS/LDFLAGS. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
