On 22.03.15 19:28, Koosha Khajehmoogahi wrote: > Signed-off-by: Koosha Khajehmoogahi <koo...@posteo.de> > --- > t/t4202-log.sh | 141 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 141 insertions(+) > > diff --git a/t/t4202-log.sh b/t/t4202-log.sh > index 5f2b290..ab6f371 100755 > --- a/t/t4202-log.sh > +++ b/t/t4202-log.sh > @@ -428,6 +428,147 @@ cat > expect <<\EOF > * initial > EOF > > +cat > only_merges <<EOF
- please no space after the ">" - please add the && at the end of the line: cat >only_merges <<EOF && (And the same further down) > +test_expect_success 'log with config log.merges=show' ' > + git config log.merges show && Indent with TAB is good > + git log --pretty=tformat:%s >actual && but indent with 4 spaces not ideal, please use a TAB as well. > + test_cmp both_commits_merges actual && > + git config --unset log.merges Do we need the unset here? The log.merges is nicely set up before each test case, so can we drop the unset lines ? (Or do I miss something ?) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
